fix: update prometheus.rules.json with new schema

[monteiro-renato]

Related with > SchemaStore/schemastore#4148

[vishiy]

Thanks for your PR @monteiro-renato .

[vishiy]

@moshemal - can one of you validate this data type addition for expr and approve, after which we can merge ?

[monteiro-renato]

@microsoft-github-policy-service agree

[github-actions]

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[monteiro-renato]

Still interested but awaiting feedback from codeowners.

[vishiy]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[monteiro-renato]

I noticed a new PR will fix the tests > #1008 so I reverted my changes and this PR will only have the changes to the schema.

[github-actions]

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[monteiro-renato]

Still interested but awaiting feedback from codeowners.

[vishiy]

@moshemal - please check and review the schema changes and add Noam if needed...

[vishiy]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[monteiro-renato]

Hey 👋
I've added both changes I suggested to my own fork last week and I saw no issues deploying the ARM templates: https://github.com/monteiro-renato/prometheus-collector/tree/with-piped-input.

Here's an example of what I was trying to deploy initially and failing due to the schema only accepting strings in the expr field:

Not sure how testing is done on your side but you can add a test where the expression field in the prometheus rule is a number instead of a string and see how it goes.

[monteiro-renato]

Partial yaml config:

  groups:
  - interval: 60s
    name: traefik-availability-generic
    rules:
    - expr: "0.9990000000000001"
      labels:
        slo: traefik-availability
      record: pyrra_objective
    - expr: 2419200
      labels:
        slo: traefik-availability
      record: pyrra_window

[vishiy]

/azp run

[azure-pipelines]

No pipelines are associated with this pull request.

[monteiro-renato]

@vishiy, any idea why CI is failing?

[vishiy]

@vishiy, any idea why CI is failing?

Hi @monteiro-renato - permissions issue. i will create a branch off of your pr and then merge soon after a few other merges. apologies for the delay.

[vishiy]

#1026

[monteiro-renato]

Thx, Looks like it's all green now.
I will close this one then.

[vishiy]

Thx, Looks like it's all green now. I will close this one then.

thank you!