Update recommendedMetricAlerts.json #756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parentheses
Sohamdg081992
approved these changes
Feb 27, 2024
|
Thanks @jacobaccumulus for catching this. This is a copy paste bug which got introduced in the Arm template and also in bicep(since it is generated from arm). I have double checked all the recommended alerts in our repo(both arm and bicep) for syntax errors in Grafana and this was the only one. I have made a pr to update both the templates here #757. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parentheses were missing in one alert, causing deployment to fail with a missing parentheses error.
Tested using azurerm_resource_group_template_deployment terraform resource and http data block pointing at this repo (fails with missing parentheses error) and then my fork (succeeds, all rules created).
I understand this is likely a generated file so it may just point to a bug somewhere else but wanted to raise attention in order to get it fixed.