Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arm and Bicep templates for recommended metric alerts #730

Closed
wants to merge 1 commit into from

Conversation

Sohamdg081992
Copy link
Contributor

This change updates Arm and Bicep templates for recommended metric alerts

@Sohamdg081992 Sohamdg081992 requested a review from a team as a code owner January 25, 2024 01:49
@@ -1,438 +0,0 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see this deleted file is currently referenced by https://aka.ms/azureprometheus-communityalerts from documentation...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I deleted this by mistake. I will add them back and will delete after updating the public doc to point to the new file. Thanks for catching!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reset soft the git commit to put the files back and now the branch got locked out and won't let me push. Created a new pr #731 from a new branch. Sorry about that.

@@ -1,534 +0,0 @@
param monitorWorkspaceName string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this deleted file is currently referenced by https://aka.ms/azureprometheus-alerts-bicep in our docs....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, I deleted this by mistake. Adding back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants