networkobservability-metrics #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matmerr
commented
Nov 2, 2023
otelcollector/configmapparser/tomlparser-default-targets-metrics-keep-list.rb
Outdated
Show resolved
Hide resolved
matmerr
force-pushed
the
netobsmetrics
branch
from
23126b9 to
53d9ef3
Compare
matmerr
force-pushed
the
netobsmetrics
branch
from
71ad651 to
25fbf7a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vishiy
reviewed
Nov 15, 2023
|
https://grafana.com/grafana/dashboards/18814-kubernetes-networking/ Grafana dashboard using this new metrics. We will remove old kappie_ metric references after rollout of AMA with this change and our service with new metrics name. |
otelcollector/configmapparser/prometheus-config-merger-with-operator.rb
Outdated
Show resolved
Hide resolved
otelcollector/configmapparser/prometheus-config-merger-with-operator.rb
Outdated
Show resolved
Hide resolved
otelcollector/configmapparser/default-prom-configs/networkobservabilityRetinaDefaultDs.yml
Show resolved
Hide resolved
rashmichandrashekar
previously approved these changes
Nov 22, 2023
rashmichandrashekar
approved these changes
Nov 22, 2023
vakalapa
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@matmerr - can u please put link to grafana dashboards for the team to look as part of PR review please ?
@Azure/prometheus-collector-devs - please review
Scrape configuration is as follows:
In the network-observability-svc the ports will be added/removed as necessary depending on the type of cluster and components installed from RP view