Step 0 : Merge CCP changes to main with a separate image #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rometheus-collector into operator-targetallocator
…rometheus-collector into operator-targetallocator
gracewehner
reviewed
Mar 1, 2024
otelcollector/prometheuscollector/tomlparser-ccp-prometheus-collector-settings.go
Outdated
Show resolved
Hide resolved
otelcollector/prometheuscollector/tomlparser-ccp-default-scrape-settings.go
Outdated
Show resolved
Hide resolved
sgeannina
requested changes
Mar 4, 2024
otelcollector/prometheuscollector/prometheus-ccp-config-merger.go
Outdated
Show resolved
Hide resolved
sgeannina
previously requested changes
Mar 5, 2024
bragi92
requested review from
sgeannina,
vishiy,
gracewehner,
rashmichandrashekar and
Sohamdg081992
gracewehner
previously approved these changes
Mar 13, 2024
bragi92
dismissed
sgeannina’s stale review
addressed changes and re-requested review
gracewehner
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.