Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure build fails if image build fails #642

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Conversation

gracewehner
Copy link
Contributor

Move setting the payload.json file for signing out of build image task, since ADO only fails based on the last return code

@gracewehner gracewehner requested a review from a team as a code owner October 18, 2023 22:41
vishiy
vishiy previously approved these changes Oct 18, 2023
Sohamdg081992
Sohamdg081992 previously approved these changes Oct 18, 2023
@gracewehner gracewehner enabled auto-merge (squash) October 18, 2023 23:56
vishiy
vishiy previously approved these changes Oct 19, 2023
@gracewehner gracewehner disabled auto-merge October 19, 2023 16:58
@gracewehner gracewehner dismissed stale reviews from vishiy and Sohamdg081992 via 0146f1d October 19, 2023 17:44
@github-actions github-actions bot added size/S and removed size/XS labels Oct 19, 2023
vishiy
vishiy previously approved these changes Oct 19, 2023
@gracewehner gracewehner enabled auto-merge (squash) October 19, 2023 19:30
@gracewehner gracewehner merged commit 32467cc into main Oct 19, 2023
16 checks passed
@gracewehner gracewehner deleted the grace/build-fix branch February 7, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants