Adding ama-metrics to customer control plane #639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial version
Enable all targets from PRD
Refactor plugin
* Adding missing config for prom collector health in control plane * Cleanup and fixes from testing --------- Co-authored-by: Nina Segares <[email protected]>
* Adding new sidecar to sync configmap changes --------- Co-authored-by: Nina Segares <[email protected]>
* Enable health collector * Removing sidecar from repo --------- Co-authored-by: Nina Segares <[email protected]>
sgeannina
commented
Oct 18, 2023
| @@ -0,0 +1,182 @@ | |||
| FROM --platform=$BUILDPLATFORM mcr.microsoft.com/oss/go/microsoft/golang:1.19 as fluent-bit-builder | |||
There was a problem hiding this comment.
I'll remove this file in the final PR
sgeannina
commented
Oct 18, 2023
| scrape_configs: | ||
| - job_name: cluster-autoscaler | ||
| scrape_interval: $$SCRAPE_INTERVAL$$ | ||
| follow_redirects: false |
There was a problem hiding this comment.
would these files be replaced by the new configmap @bragi92 ?
There was a problem hiding this comment.
Yes, I'm currently working on copying these over into my branch and creating an image based on that. I will share a PR link when its ready.
sgeannina
commented
Oct 18, 2023
| regex: (.+) | ||
| - source_labels: [ __address__, __meta_kubernetes_pod_annotation_aks_prometheus_io_port ] | ||
| action: replace | ||
| separator: ":" |
There was a problem hiding this comment.
we need to replace the address with "regex: (.+?)(:\d+)?" but keeping it like this while we test in standalone
|
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 12 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending changes:
New:
-- Remove scraping interval from settings and keep it to 30s
-- Remove prometheus collector health from ccp
-- Add prefix to all metrics: control-plane