Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add explicit step to check configmap applies for controlPlane to buildandrelease docs #1022

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

davidkydd
Copy link
Contributor

Add explicit step for testing configmap applies for ControlPlane metrics to buildandrelease docs, and additional targets to test configmap yaml.

Note I am unaware of other usages of the test settings configmap that is being modified here, if there are some that will be incompatible be this change, it may be necessary to create and reference a separate .yaml file.

@davidkydd davidkydd requested a review from a team as a code owner December 3, 2024 03:09
@github-actions github-actions bot added the size/S label Dec 3, 2024
@davidkydd davidkydd changed the title Dakydd/builddocs e2e cmtest docs: Add explicit step to check configmap applies for controlPlane to buildandrelease docs Dec 3, 2024
@vishiy
Copy link
Contributor

vishiy commented Dec 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vishiy vishiy merged commit 153d0f5 into main Dec 8, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants