Skip to content

Commit

Permalink
Rashmi/update operator deployment (#931)
Browse files Browse the repository at this point in the history
[comment]: # (Note that your PR title should follow the conventional
commit format: https://conventionalcommits.org/en/v1.0.0/#summary)
# PR Description
AKS RP PR -
https://msazure.visualstudio.com/DefaultCollection/CloudNativeCompute/_git/aks-rp/pullrequest/9971078
Updating deployment specs for ama-metrics-operator-targets as this pod
was not getting cleaned up by GC on low memory evictions due to memory
pressure

[comment]: # (The below checklist is for PRs adding new features. If a
box is not checked, add a reason why it's not needed.)
# New Feature Checklist

- [ ] List telemetry added about the feature.
- [ ] Link to the one-pager about the feature.
- [ ] List any tasks necessary for release (3P docs, AKS RP chart
changes, etc.) after merging the PR.
- [ ] Attach results of scale and perf testing.

[comment]: # (The below checklist is for code changes. Not all boxes
necessarily need to be checked. Build, doc, and template changes do not
need to fill out the checklist.)
# Tests Checklist

- [ ] Have end-to-end Ginkgo tests been run on your cluster and passed?
To bootstrap your cluster to run the tests, follow [these
instructions](/otelcollector/test/README.md#bootstrap-a-dev-cluster-to-run-ginkgo-tests).
  - Labels used when running the tests on your cluster:
    - [ ] `operator`
    - [ ] `windows`
    - [ ] `arm64`
    - [ ] `arc-extension`
    - [ ] `fips`
- [ ] Have new tests been added? For features, have tests been added for
this feature? For fixes, is there a test that could have caught this
issue and could validate that the fix works?
  - [ ] Is a new scrape job needed?
- [ ] The scrape job was added to the folder
[test-cluster-yamls](/otelcollector/test/test-cluster-yamls/) in the
correct configmap or as a CR.
  - [ ] Was a new test label added?
- [ ] A string constant for the label was added to
[constants.go](/otelcollector/test/utils/constants.go).
- [ ] The label and description was added to the [test
README](/otelcollector/test/README.md).
- [ ] The label was added to this [PR
checklist](/.github/pull_request_template).
- [ ] The label was added as needed to
[testkube-test-crs.yaml](/otelcollector/test/testkube/testkube-test-crs.yaml).
  - [ ] Are additional API server permissions needed for the new tests?
- [ ] These permissions have been added to
[api-server-permissions.yaml](/otelcollector/test/testkube/api-server-permissions.yaml).
  - [ ] Was a new test suite (a new folder under `/tests`) added?
- [ ] The new test suite is included in
[testkube-test-crs.yaml](/otelcollector/test/testkube/testkube-test-crs.yaml).
  • Loading branch information
rashmichandrashekar authored Jul 3, 2024
1 parent eabe067 commit 598e5e5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 24 deletions.
1 change: 1 addition & 0 deletions .trivyignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ CVE-2023-45290
CVE-2024-24783
CVE-2024-24784
CVE-2024-24785
CVE-2024-6104
# MEDIUM - promconfigvalidator
CVE-2023-48795
CVE-2024-24786
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
spec:
progressDeadlineSeconds: 600
replicas: 1
revisionHistoryLimit: 10
revisionHistoryLimit: 2
selector:
matchLabels:
rsName: ama-metrics-operator-targets
Expand All @@ -22,11 +22,15 @@ spec:
type: RollingUpdate
template:
metadata:
creationTimestamp: null
labels:
rsName: ama-metrics-operator-targets
kubernetes.azure.com/managedby: aks
annotations:
agentVersion: "0.0.0.1"
schema-versions: "v1"
cluster-autoscaler.kubernetes.io/safe-to-evict: "true"
spec:
priorityClassName: system-cluster-critical
containers:
- name: targetallocator
args:
Expand Down Expand Up @@ -215,31 +219,9 @@ spec:
- key: CriticalAddonsOnly
operator: Exists
{{- if eq (default .Values.tolerationsOnlyForControlPlane false) false }}
- operator: "Exists"
effect: "NoSchedule"
- operator: "Exists"
effect: "NoExecute"
- operator: "Exists"
effect: "PreferNoSchedule"
{{- end }}
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoSchedule"
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "NoExecute"
- key: "node-role.kubernetes.io/control-plane"
operator: "Exists"
effect: "PreferNoSchedule"
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoSchedule"
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "NoExecute"
- key: "node-role.kubernetes.io/master"
operator: "Exists"
effect: "PreferNoSchedule"
volumes:
- name: settings-vol-config
configMap:
Expand Down

0 comments on commit 598e5e5

Please sign in to comment.