Fixes #2126 - Adds configuration of upstream protocol in cloud based mode #2129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metal-Mighty
force-pushed
the
bugfix/2126-upstreamprotocol
branch
3 times, most recently
from
090eead to
e4db540
Compare
Currently supports Amqp or AmqpWs
Amqp was the default protocol in cloud-based mode before, keeping it the same for compatibility
Metal-Mighty
force-pushed
the
bugfix/2126-upstreamprotocol
branch
from
e4db540 to
c013efd
Compare
|
@microsoft-github-policy-service agree company="Michelin" |
Mandur
approved these changes
Sep 22, 2024
|
We cannot run the CI on this branch, therefore it is not possible to merge it at the moment. I am currently in travel I will have a look when I come back |
Mandur
reviewed
Oct 9, 2024
| @@ -10,7 +10,7 @@ namespace LoRaWan.Tests.Unit.NetworkServer | |||
| using System.Linq; | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
| using LoRaWan.NetworkServer; | |||
| using LoRaWan.NetworkServer.Extensions; | |||
There was a problem hiding this comment.
I had to revert this change to have it compiled
Mandur
reviewed
Oct 9, 2024
| @@ -5,7 +5,7 @@ namespace LoRaWan.Tests.Unit.NetworkServer | |||
| { | |||
| using System; | |||
| using System.Threading; | |||
| using LoRaWan.NetworkServer; | |||
| using LoRaWan.NetworkServer.Extensions; | |||
There was a problem hiding this comment.
I had to revert this change to have it compiled
|
There is still a problem with our CI to accept the external change - however when running the PR locally in addition to the code changes I see some tests failing: 
|
|
Hi @Mandur Thanks for the feedback. Weird about the revert, we have a working build on our environment. It's true I didn't check the unit tests though ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #2126
What is being addressed
Adds the ability to configure the Upstream Protocol for AMQP communication between Azure Device Clients and Azure IoT Hub in cloud-based mode.
This setting was present in the edgeHub module when not in cloud-based mode and the LNS forced communication in AMQP TCP, which uses different port than AMQP WS and can break in restricted network environments.
How is this addressed
UPSTREAM_PROTOCOLenvironment variable and anUpstreamProtocolproperty in the LNS configurationAmqporAmqpWs)Amqp) the default value (same as before)