Custom Repo Fixes #434
Merged
Custom Repo Fixes #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this is no longer dearmoring keys at all? |
Yes. It should not be needed as long as the file extension on the keys is correct. |
|
There may be something in the docs about this, can you update that? |
…es. This way we can fill in permissions by default if they are on an http source that is nested under a key, and let apt handle the key based on its format (though the file extension still must be correct). Remove worker parameter for GetRepoKeys as dearmoring is no longer needed
Update http source docs now that digest verification and file permissions are supported options
adamperlin
force-pushed
the
adamperlin/custom-repo-fixes
branch
from
b8468d9
to
22330ce
Compare
|
Docs are now updated |
cpuguy83
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a few fixes for the custom repos feature.
permissionsfield to the http source. This allows us to fill in the permissions by default if they are on an http source that is nested under a key. It is important that fetched gpg keys have the proper permissions, otherwise apt cannot import them properly. Assuming that they do have proper permissions, apt can handle both.ascand.gpgkeys just fine. This makes the explicit de-armor step unnecessary and means we no longer need gpg as a dependency in the jammy worker images.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #425
Special notes for your reviewer: