Use async states #390
Open
Use async states #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to put merges under a progress group and is purely cosmetic. Signed-off-by: Brian Goff <[email protected]>
This wraps the signer in an async state so it can be lazily evaluated regardless of if the actual signer needs to unlazy the build. Signed-off-by: Brian Goff <[email protected]>
Before this was returning early when there are file-based errors, however it is still helpful to run the rest of the tests so we can see all errors in one go. Signed-off-by: Brian Goff <[email protected]>
This generally cleans up some things in the test runner a little bit and makes it so more checks are run in parallel and mostly avoids needing to unlazy the build while we are processing the spec. It also does a better job of collecting and returning errors related to failed tests rather than returning just a single error immediately on a single test failure. Before this change the for loops may block to solve states and prevent progress from happening. Signed-off-by: Brian Goff <[email protected]>
pmengelbert
requested changes
Nov 13, 2024
| @@ -247,6 +247,14 @@ func getSignConfigCtxName(client gwclient.Client) string { | |||
|
|
|||
| type asyncStateFunc func(context.Context, llb.State, *llb.Constraints) (llb.State, error) | |||
|
|
|||
| func withConstraints(in *llb.Constraints) dalec.ConstraintsOptFunc { | |||
There was a problem hiding this comment.
There's now a project-wide solution for this, dalec.WithConstraints
| for k, st := range inputs { | ||
| def, err := st.Marshal(ctx, withConstraints) | ||
| def, err := st.Marshal(ctx, withConstraints(constraints)) |
| if err != nil { | ||
| return llb.Scratch(), err | ||
| } | ||
| m[k] = def.ToPB() | ||
| } | ||
| req.FrontendInputs = m | ||
|
|
||
| stateDef, err := st.Marshal(ctx, withConstraints) | ||
| stateDef, err := st.Marshal(ctx, withConstraints(constraints)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of async states to help prevent unlazying builds until we are ready to solve things.
See individual commits for more details.