Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added KeyVault key & secret outputs #3603

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Oct 21, 2024

Description

Pipeline Reference

Pipeline
avm.res.key-vault.vault

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 21, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Oct 21, 2024

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@AlexanderSehr AlexanderSehr self-assigned this Oct 21, 2024
@AlexanderSehr AlexanderSehr added Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it and removed Needs: Triage 🔍 Maintainers need to triage still labels Oct 21, 2024
@AlexanderSehr AlexanderSehr changed the title feat: Added KeyVault key outputs feat: Added KeyVault key & secret outputs Oct 21, 2024
@AlexanderSehr AlexanderSehr linked an issue Oct 24, 2024 that may be closed by this pull request
1 task
@jtracey93
Copy link
Contributor

Hey @AlexanderSehr ,

Firstly, thanks for your work on this PR!

We have made some changes to the AVM CI, detailed below, which means we need you to update your fork to pull in these latest changes and re-run your tests to show they still are passing prior to approving and merging this PR, as we don't and it fails once merged the publishing of your module will fail and will be blocked going forward until the test pass again via additional PRs.

Changes to CI That Have Been Made That You Need To Take Action On

Any questions reach out to the AVM Core Team by tagging us in your PR here or internally via Teams

Thanks

Jack (AVM Core Team)

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 28, 2024 21:46
@AlexanderSehr AlexanderSehr requested review from a team as code owners November 28, 2024 21:46
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) November 28, 2024 21:46
@AlexanderSehr AlexanderSehr merged commit 822542f into Azure:main Nov 29, 2024
5 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/Gosselin-l_keyvault_key_moreOutputs branch November 29, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: add more outputs to the key submodule
5 participants