Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spark example jobs to spark 3.4 #3471

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Spark example jobs to spark 3.4 #3471

wants to merge 6 commits into from
+20 −20

Conversation

vaibhj
Copy link
Contributor

@vaibhj vaibhj commented Dec 13, 2024 •
edited
Loading

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

alanpo1
alanpo1 reviewed Dec 13, 2024
View reviewed changes
sdk/python/jobs/spark/submit_spark_pipeline_jobs.ipynb
@@ -342,7 +342,7 @@
" spark_step.identity = ManagedIdentityConfiguration()\n",
" spark_step.resources = {\n",
" \"instance_type\": \"Standard_E8S_V3\",\n",
" \"runtime_version\": \"3.3.0\",\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you actually set this as 2-digit not 3, aka 3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanpo1 alanpo1 alanpo1 left review comments

@ycheng35xo ycheng35xo ycheng35xo approved these changes

@sdgilley sdgilley Awaiting requested review from sdgilley sdgilley is a code owner

@msakande msakande Awaiting requested review from msakande msakande is a code owner

@Blackmist Blackmist Awaiting requested review from Blackmist Blackmist is a code owner

@ssalgadodev ssalgadodev Awaiting requested review from ssalgadodev ssalgadodev is a code owner

@lgayhardt lgayhardt Awaiting requested review from lgayhardt lgayhardt is a code owner

@fbsolo-ms1 fbsolo-ms1 Awaiting requested review from fbsolo-ms1 fbsolo-ms1 is a code owner

@ahughes-msft ahughes-msft Awaiting requested review from ahughes-msft ahughes-msft is a code owner

@yunjie-hub yunjie-hub Awaiting requested review from yunjie-hub yunjie-hub is a code owner

@nemanjarajic nemanjarajic Awaiting requested review from nemanjarajic nemanjarajic is a code owner

@kingernupur kingernupur Awaiting requested review from kingernupur kingernupur is a code owner

@jayesh-tanna jayesh-tanna Awaiting requested review from jayesh-tanna jayesh-tanna is a code owner

@achauhan-scc achauhan-scc Awaiting requested review from achauhan-scc achauhan-scc is a code owner

@imatiach-msft imatiach-msft Awaiting requested review from imatiach-msft imatiach-msft is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaibhj @ycheng35xo @alanpo1