Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detach compute before attaching, as k8s compute doesn't support update #3030

Merged
merged 6 commits into from
Mar 26, 2024
Merged

detach compute before attaching, as k8s compute doesn't support update #3030

merged 6 commits into from
Mar 26, 2024

Conversation

zetiaatgithub
Copy link
Contributor

@zetiaatgithub zetiaatgithub commented Mar 1, 2024 •
edited
Loading

Description

Checklist

  • I have read the contribution guidelines.
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

@zetiaatgithub zetiaatgithub changed the title detach compute before attaching detach compute before attaching, as k8s compute doesn't support update Mar 5, 2024
@zetiaatgithub zetiaatgithub merged commit 735144d into main Mar 26, 2024
349 of 387 checks passed
@zetiaatgithub zetiaatgithub deleted the zetia/check-compute-before-creation branch March 26, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youhuatuyh youhuatuyh youhuatuyh approved these changes

@RichardZhaoW RichardZhaoW RichardZhaoW approved these changes

@mjaow mjaow mjaow approved these changes

@cloga cloga cloga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zetiaatgithub @cloga @mjaow @RichardZhaoW @youhuatuyh