Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md and add sdk/CONTRIBUTING.md #2693

Merged
merged 21 commits into from
Oct 26, 2023
Merged

Update CONTRIBUTING.md and add sdk/CONTRIBUTING.md #2693

merged 21 commits into from
Oct 26, 2023

Conversation

diondrapeck
Copy link
Member

@diondrapeck diondrapeck commented Sep 29, 2023 •
edited
Loading

Description

This PR updates contributing standards

  • SDK examples should be Jupyter Notebooks
  • Links to a Jupyter Notebook template
  • Updates guidance for READMEs

Checklist

  • I have read the contribution guidelines
  • I have coordinated with the docs team ([email protected]) if this PR deletes files or changes any file names or file extensions.
  • Pull request includes test coverage for the included changes.
  • This notebook or file is added to the CODEOWNERS file, pointing to the author or the author's team.

diondrapeck and others added 20 commits August 28, 2023 15:54
@diondrapeck
Update CONTRIBUTING.md
349ca09
@diondrapeck
Add CODEOWNERS check to pull request template
9361756
@diondrapeck
Update CONTRIBUTING.md Goals section
ae65f9b
@diondrapeck
Update CONTRIBUTING.md Goals section
4b74666
@diondrapeck
Fix typos
67950d2
@diondrapeck
Merge branch 'main' into update-contributing
64c20bf
@diondrapeck
Update CONTRIBUTING.md Non-goals section
06dfeab
@diondrapeck
Update wording for Non-goals
47adc65
@diondrapeck
Merge branch 'main' into update-contributing
a590b6e
@diondrapeck
Update CONTRIBUTING.md additional resources
14ff497
@diondrapeck
Merge branch 'update-contributing' of https://github.com/Azure/azurem…
d8eddb7 
…l-examples into update-contributing
@diondrapeck
Resolve merge conflict
97026e9
@diondrapeck
Update main contributing guide
833e322
@diondrapeck
Add SDK contributing guide
6ca6f88
@diondrapeck
Update pull request template
1582b56
@diondrapeck
Update pull request template
051ac49
@diondrapeck
Remove pull request merge/approval section
1fdbf5f
@diondrapeck
Add notice about code samples update timing
7766c58
@diondrapeck
Merge branch 'update-contributing' of https://github.com/Azure/azurem…
f0405b7 
…l-examples into update-contributing
@diondrapeck
Add link to template
c3c1110
@diondrapeck diondrapeck marked this pull request as ready for review October 25, 2023 20:59
@kdestin kdestin merged commit cfed266 into main Oct 26, 2023
6 checks passed
@kdestin kdestin deleted the update-contributing branch October 26, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdestin kdestin kdestin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diondrapeck @kdestin