Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[notification hubs] Adding Xiaomi support #25171

Merged
merged 7 commits into from
Mar 9, 2023
Merged

[notification hubs] Adding Xiaomi support #25171

merged 7 commits into from
Mar 9, 2023

Conversation

mpodwysocki
Copy link
Member

Packages impacted by this PR

  • @azure/notification-hubs

Issues associated with this PR

Describe the problem that is addressed by this PR

Adds Xiaomi support for Track 2 SDKs with registration, installation, send and send outcome operations.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

yes

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-notification-hubs

Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the version

sdk/notificationhubs/notification-hubs/CHANGELOG.md Outdated Show resolved Hide resolved
sdk/notificationhubs/notification-hubs/package.json Outdated Show resolved Hide resolved
@mpodwysocki mpodwysocki enabled auto-merge (squash) March 9, 2023 22:32
@mpodwysocki
Copy link
Member Author

/check-enforcer evaluate

@mpodwysocki
Copy link
Member Author

/check-enforcer override

@mpodwysocki mpodwysocki merged commit 6f3c076 into main Mar 9, 2023
@mpodwysocki mpodwysocki deleted the feat/nh-xiaomi branch March 9, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants