-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk automation, support breaking change detection #40917
Conversation
@raych1 Would you help take a look at the GenerateApiView error in pipeline? It's looking for non-exist artifact Apart from that, sdk automation completed with success: |
@XiaofeiCao Regarding APIView failures, I noticed that it fails for Java in other test PRs too. But API view was created successfully for other languages. We shall take a further look. |
The "mgmt SDK generation" part is for generating SDK for release. No changelog nor breaking change flag would sent to you or your pipeline. Here we uses our existing logic (mostly, GA compares with GA, preview compares with a prior version) for SDK changelog. Only the "SDK Automation" relates to you / PR. |
We didn't touch existing codegen logic, like Weidong explained above. This PR's only about SDK automation.
Thanks. Java's error is strange, since the output apiViewArtifact looks OK to me: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3923824&view=logs&j=a8a7a537-82b0-583c-7971-bac70b9822ca&t=37e3947b-3cfb-5d36-86ba-0e22bb7dbc33&l=1484 |
APIView has been generated successfully in this PR for Java, the failure in this PR should not be related to your changes. |
Thanks @raych1 ! |
/check-enforcer override |
Description
For SDK Automation, breaking change is compared with last GA version(new feature, this is about this PR).
For mgmt SDK generation, breaking change is compared with last released version(existing feature, not related to this PR).
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines