Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add componentsByReleases in UpgradeProfile #29002

Merged
merged 1 commit into from
May 17, 2024
+40 −0
Merged

add componentsByReleases in UpgradeProfile #29002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions ...ce-manager/Microsoft.ContainerService/aks/preview/2024-04-02-preview/managedClusters.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6499,6 +6499,9 @@
},
"x-ms-identifiers": [],
"description": "List of orchestrator types and versions available for upgrade."
},
"componentsByReleases": {
"$ref": "#/definitions/ComponentsByReleases"
}
},
"required": [
Expand Down Expand Up @@ -6948,6 +6951,9 @@
"x-ms-identifiers": [],
"description": "List of orchestrator types and versions available for upgrade."
},
"componentsByReleases": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't realized that after I approved this, the name of the property was changed from componentVersions to componentsByReleases. I'm not convinced this is a better name (though I do like the structure that Haitao proposed).

I would've suggested we call it componentsByVersion or maybe just components. The word release is confusing IMO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely too late to fix this for this API version though. Couple options here:

  1. Release as-is, change in the next version. It's a breaking change but that's allowed in preview so not a big deal.
  2. Delay this feature to the next API version and fix it there.
  3. Don't fix it at all and just go with componentsByReleases.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuShaoRu any update?

"$ref": "#/definitions/ComponentsByReleases"
},
"latestNodeImageVersion": {
"type": "string",
"description": "The latest AKS supported node image version."
Expand Down Expand Up @@ -10003,6 +10009,40 @@
}
},
"description": "The names of the load balancers to rebalance. If set to empty, all load balancers will be rebalanced."
},
"Component": {
"type": "object",
"properties": {
"name": {
"type": "string",
"description": "Component name."
},
"version": {
"type": "string",
"description": "Component version."
},
"hasBreakingChanges": {
"type": "boolean",
"description": "If upgraded component version contains breaking changes from the current version. To see a detailed description of what the breaking changes are, visit https://learn.microsoft.com/azure/aks/supported-kubernetes-versions?tabs=azure-cli#aks-components-breaking-changes-by-version."
}
}
},
"ComponentsByReleases": {
"type": "object",
"properties": {
"kubernetesVersion": {
"type": "string",
"description": "The Kubernetes version (major.minor)."
},
"components": {
"type": "array",
"items": {
"$ref": "#/definitions/Component"
},
"description": "components of current or upgraded Kubernetes version in the cluster."
}
},
"description": "components of given Kubernetes version."
}
},
"parameters": {
Expand Down