[AKS][Fleet] 2024-05-02-preview API #28971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preview/2023-08-15-preview to version 2024-02-02-preview
* manual skip API * copied examples * fix typo * fix example * add missing examples * add missing examples * fix examples * fix examples * fix examples * fix examples * fix examples * fix examples * fix examples * add fleet hub profile back * custom-words
* rename skip target * identifier * fix examples * format
* readme files * fix typo * fix typo
* Add autoupgradeprofile * list update run by autoupgradeprofile * add x-ms-example * fix name pattern * add latest tag * compile . * custom node * remove listUpdateRuns as POST route * complete removal of listupdateruns as post * generateUpdateRuns * generateupdateruns * clean up * remove listUpdateRuns * undo change * update decorator * visibility --------- Co-authored-by: nguyenmin <[email protected]>
* Custom node image upgrade type in UpdateRun * node image custom example --------- Co-authored-by: nguyenmin <[email protected]>
zman-ms
requested review from
weshaggard,
mikeharder,
konrad-jamrozik,
palma21,
weinong,
alvinli222,
matthchr and
circy9
as code owners
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| fleets.json | 2024-05-02-preview(0855bbc) | 2024-04-01(main) |
| fleets.json | 2024-05-02-preview(0855bbc) | 2024-02-02-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
| Rule | Message |
|---|---|
| The new version is adding a path that was not found in the old version. New: fleet/preview/2024-05-02-preview/fleets.json#L472:5 |
|
| The new version is adding a path that was not found in the old version. New: fleet/preview/2024-05-02-preview/fleets.json#L524:5 |
The following breaking changes are detected by comparison with the latest preview version:
| Rule | Message |
|---|---|
| The new version is adding a path that was not found in the old version. New: fleet/preview/2024-05-02-preview/fleets.json#L472:5 |
|
| The new version is adding a path that was not found in the old version. New: fleet/preview/2024-05-02-preview/fleets.json#L524:5 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 19 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-2024-05-preview | package-2024-05-preview(0855bbc) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
This was referenced May 3, 2024
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Azure Pipelines successfully started running 3 pipeline(s). |
microsoft-github-policy-service
bot
added
the
no-recent-activity
|
/azp run |
|
Commenter does not have sufficient privileges for PR 28971 in repo Azure/azure-rest-api-specs |
microsoft-github-policy-service
bot
removed
the
no-recent-activity
AzureRestAPISpecReview
added
the
ReadyForApiTest
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
AzureRestAPISpecReview
added
BreakingChangeReviewRequired
AzureRestAPISpecReview
added
WaitForARMFeedback
razvanbadea-msft
added
the
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
|
wow thanks for the speedy review @razvanbadea-msft ! |
serbrech
added
the
PublishToCustomers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.