Microsoft.ContainerInstance: Added API version 2024-05-01-preview #28964

drishtipeshwani09 · 2024-05-03T09:54:18Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from stable/2023-05-01 to preview/2024-05-01-preview.

…Pool to Container Group Properties and ConfigMap to ContainerProperties specs and modified examples

openapi-pipeline-app · 2024-05-03T09:54:22Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-05-03T09:54:23Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️❌Breaking Change(Cross-Version): 3 Errors, 7 Warnings failed [Detail]

Compared specs (v0.10.12)	new version	base version
containerInstance.json	2024-05-01-preview(e2ab4eb)	2023-05-01(main)
containerInstance.json	2024-05-01-preview(e2ab4eb)	2023-02-01-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule	Message
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L861:7 Old: Microsoft.ContainerInstance/stable/2023-05-01/containerInstance.json#L862:7
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/stable/2023-05-01/containerInstance.json#L1400:11
`❌` 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/stable/2023-05-01/containerInstance.json#L1400:11

The following breaking changes are detected by comparison with the latest preview version:

Rule	Message
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L861:7 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L853:7
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1391:11
⚠️ 1025 - RequiredStatusChange	The 'required' status changed from the old version('True') to the new version('False'). New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1391:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'provisioningTimeoutInSeconds' renamed or removed? New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1391:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'isCustomProvisioningTimeout' renamed or removed? New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1391:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'provisioningTimeoutInSeconds' renamed or removed? New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1391:11
⚠️ 1033 - RemovedProperty	The new version is missing a property found in the old version. Was 'isCustomProvisioningTimeout' renamed or removed? New: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1417:11 Old: Microsoft.ContainerInstance/preview/2023-02-01-preview/containerInstance.json#L1391:11

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️⚠️LintDiff: 2 Warnings warning [Detail]

Compared specs (v2.2.2)	new version	base version
package-preview-2024-05	package-preview-2024-05(e2ab4eb)	default(main)

[must fix]The following errors/warnings are introduced by current PR:

Rule	Message	Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1573
⚠️ EnumInsteadOfBoolean	Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L1610

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule	Message
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L113
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L221
`❌` PatchIdentityProperty	The patch operation body parameter schema should contain property 'identity'. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L249
`❌` UnSupportedPatchProperties	Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L249
`❌` DeleteResponseCodes	Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L274
`❌` DeleteResponseBodyEmpty	The delete response body must be empty. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L300
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L304
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L313
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L320
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L321
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L351
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L358
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L395
`❌` PostResponseCodes	Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L396
`❌` LroLocationHeader	A 202 response should include an Location response header. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L420
`❌` LroErrorContent	Error response content of long running operations must follow the error schema provided in the common types v2 and above. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L429
`❌` OperationsApiResponseSchema	The response schema of operations API '/providers/Microsoft.ContainerInstance/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L456
`❌` OperationsApiSchemaUsesCommonTypes	Operations API path must follow the schema provided in the common types. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L457
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L495
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L511
`❌` ResourceNameRestriction	The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L511
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L512
`❌` GetCollectionOnlyHasValueAndNextLink	Get endpoints for collections of resources must only have the `value` and `nextLink` properties in their model. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L558
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L571
`❌` ResourceNameRestriction	The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L571
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L627
`❌` ResourceNameRestriction	The resource name parameter 'containerName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L627
`❌` ResourceNameRestriction	The resource name parameter 'containerGroupName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L754
`❌` XmsPageableForListCalls	`x-ms-pageable` extension must be specified for LIST APIs. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L755
`❌` ResourceNameRestriction	The resource name parameter 'virtualNetworkName' should be defined with a 'pattern' restriction. Location: Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json#L790

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-03T09:54:23Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️⚠️ azure-sdk-for-net-track2 warning [Detail]

FAQ

⚠️Warning in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] Get-ChildItem: /mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:787
cmderr	[Invoke-GenerateAndBuildV2.ps1] Line |
cmderr	[Invoke-GenerateAndBuildV2.ps1]  787 |  … rtifacts += Get-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s …
cmderr	[Invoke-GenerateAndBuildV2.ps1]      |                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | Cannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1]      | it does not exist.

️✔️Azure.ResourceManager.ContainerInstance [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-sdk-for-python warning [Detail]

FAQ

⚠️Warning in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
cmderr	[automation_init.sh] npm notice
cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[automation_init.sh] npm notice To update run: npm install -g [email protected]
cmderr	[automation_init.sh] npm notice
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json

️✔️azure-mgmt-containerinstance [Preview SDK Changes]

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Container has a new parameter config_map
info	[Changelog]   - Model ContainerGroup has a new parameter container_group_profile
info	[Changelog]   - Model ContainerGroup has a new parameter is_created_from_standby_pool
info	[Changelog]   - Model ContainerGroup has a new parameter standby_pool_profile
info	[Changelog]   - Model ContainerGroupProperties has a new parameter container_group_profile
info	[Changelog]   - Model ContainerGroupProperties has a new parameter is_created_from_standby_pool
info	[Changelog]   - Model ContainerGroupProperties has a new parameter standby_pool_profile

️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerinstance-generated [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerinstance/armcontainerinstance [Preview SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-containerinstance [Preview SDK Changes]

️❌ azure-resource-manager-schemas failed [Detail]

FAQ

❌Code Generator Failed in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.

️️✔️ azure-powershell succeeded [Detail] [Expand]

FAQ

️✔️Succeeded in generating from e724d57701ea7efb7c69ede364e185988cb1e9e9. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json

️✔️Az.containerinstance.DefaultTag [Preview SDK Changes]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2024-05-03T09:54:23Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/containerinstance/armcontainerinstance	https://apiview.dev/Assemblies/Review/94480d0264ec4820b781f6275cf6a7a8?revisionId=55f96898ad604b3db911fea927354cf2
Java	azure-resourcemanager-containerinstance-generated	https://apiview.dev/Assemblies/Review/e709fb4537c54c90a1f2c1e18ba101ab?revisionId=82143ce65439464688c8ee853a525a95
JavaScript	@azure/arm-containerinstance	https://apiview.dev/Assemblies/Review/ad27d08d33da42e195cb6b43c7dc4b68?revisionId=febde8f89f664c498d882c593d1e88d2
Swagger	Microsoft.ContainerInstance	https://apiview.dev/Assemblies/Review/57ed6af1fd4140b5b89c9b62c962949f?revisionId=85e1fe09bcb44d148d56e8c1af970f77

…iew_apiversion_2024-05-01-preview

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json

…iew_apiversion_2024-05-01-preview

drishtipeshwani09 · 2024-06-25T04:57:59Z

/azp run

azure-pipelines · 2024-06-25T04:58:17Z

Azure Pipelines successfully started running 4 pipeline(s).

…iew_apiversion_2024-05-01-preview

ramoka178 · 2024-06-25T16:28:25Z

specification/containerinstance/resource-manager/readme.md

+suppressions:
+  - code: AvoidAdditionalProperties
+    from: containerInstance.json
+    reason: Using additionalProperties type as the object is user-defined and not subject to any validations at RP level.


reason

could you please provide the path also using "where", so that the suppression is only valid in those case and not for whole file.

drishtipeshwani09 · 2024-06-25T17:08:08Z

/azp run

azure-pipelines · 2024-06-25T17:08:23Z

Azure Pipelines successfully started running 4 pipeline(s).

drishtipeshwani09 · 2024-06-25T18:14:21Z

/azp run

…iew_apiversion_2024-05-01-preview

drishtipeshwani09 · 2024-06-26T16:18:13Z

/pr RequestMerge

…iew_apiversion_2024-05-01-preview

ramoka178

Approving to merge

drishtipeshwani09 added 4 commits May 3, 2024 15:08

Copy files from stable/2023-05-01

98ba95b

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to preview/2024-05-01-preview

40d32ce

Updated the API version from stable/2023-05-01 to preview/2024-05-01-preview.

Added tag for 2024-05-01-preview in readme file

972a0fc

Added ContainerGroupProfile, StandbyPoolProfile, isCreatedFromStandby…

b6b553f

…Pool to Container Group Properties and ConfigMap to ContainerProperties specs and modified examples

azure-sdk mentioned this pull request May 3, 2024

[AutoPR containerinstance/resource-manager] Microsoft.ContainerInstance: Added API version 2024-05-01-preview azure-sdk/azure-resource-manager-schemas#4819

Draft

AzureRestAPISpecReview added the resource-manager label May 3, 2024

drishtipeshwani09 added 3 commits May 3, 2024 15:41

Corrected code style issues using prettier

43b228f

Fixed code styling issues using prettier

cc1e05d

Corrected definition types

eb6d062

drishtipeshwani09 added 2 commits May 3, 2024 16:43

Added isCreatedFromStandbyPool to container group properties in examples

08f7b0d

Corrected config map property definition in example

b5cfbf5

drishtipeshwani09 marked this pull request as ready for review May 16, 2024 17:09

Merge branch 'main' into drishtipeshwani09/containerinstance_new_prev…

ac6e091

…iew_apiversion_2024-05-01-preview

AzureRestAPISpecReview added ARMReview new-api-version WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels May 16, 2024

Merge branch 'main' into drishtipeshwani09/containerinstance_new_prev…

2780442

…iew_apiversion_2024-05-01-preview

razvanbadea-msft reviewed May 22, 2024

View reviewed changes

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json Show resolved Hide resolved

razvanbadea-msft reviewed May 22, 2024

View reviewed changes

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json Show resolved Hide resolved

razvanbadea-msft reviewed May 22, 2024

View reviewed changes

...source-manager/Microsoft.ContainerInstance/preview/2024-05-01-preview/containerInstance.json Show resolved Hide resolved

Added suppression for AvoidAdditionalProperties in readme.md

f98ddd1

AzureRestAPISpecReview added SuppressionReviewRequired WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Jun 25, 2024

Merge branch 'main' into drishtipeshwani09/containerinstance_new_prev…

49c4c19

…iew_apiversion_2024-05-01-preview

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jun 25, 2024

Merge branch 'main' into drishtipeshwani09/containerinstance_new_prev…

35f9fdc

…iew_apiversion_2024-05-01-preview

ramoka178 reviewed Jun 25, 2024

View reviewed changes

ramoka178 added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 25, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2024

Update suppression in readme.md

f9e7cfe

AzureRestAPISpecReview removed the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jun 25, 2024

Update readme.md

a493844

AzureRestAPISpecReview added the ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test label Jun 25, 2024

Merge branch 'main' into drishtipeshwani09/containerinstance_new_prev…

c2b49b4

…iew_apiversion_2024-05-01-preview

drishtipeshwani09 removed the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jun 25, 2024

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2024

ramoka178 added Approved-Suppression ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Jun 25, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2024

microsoft-github-policy-service bot added the MergeRequested label Jun 26, 2024

Merge branch 'main' into drishtipeshwani09/containerinstance_new_prev…

e2ab4eb

…iew_apiversion_2024-05-01-preview

ramoka178 approved these changes Jun 26, 2024

View reviewed changes

ramoka178 merged commit 2b6c728 into Azure:main Jun 26, 2024
30 of 32 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Microsoft.ContainerInstance: Added API version 2024-05-01-preview #28964

Microsoft.ContainerInstance: Added API version 2024-05-01-preview #28964

drishtipeshwani09 commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

drishtipeshwani09 commented Jun 25, 2024

azure-pipelines bot commented Jun 25, 2024

ramoka178 Jun 25, 2024

drishtipeshwani09 commented Jun 25, 2024

azure-pipelines bot commented Jun 25, 2024

drishtipeshwani09 commented Jun 25, 2024

drishtipeshwani09 commented Jun 26, 2024

ramoka178 left a comment

Microsoft.ContainerInstance: Added API version 2024-05-01-preview #28964

Microsoft.ContainerInstance: Added API version 2024-05-01-preview #28964

Conversation

drishtipeshwani09 commented May 3, 2024 • edited Loading

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Next Steps to Merge

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Swagger Generation Artifacts

openapi-pipeline-app bot commented May 3, 2024 • edited Loading

Generated ApiView

drishtipeshwani09 commented Jun 25, 2024

azure-pipelines bot commented Jun 25, 2024

ramoka178 Jun 25, 2024

Choose a reason for hiding this comment

drishtipeshwani09 commented Jun 25, 2024

azure-pipelines bot commented Jun 25, 2024

drishtipeshwani09 commented Jun 25, 2024

drishtipeshwani09 commented Jun 26, 2024

ramoka178 left a comment

Choose a reason for hiding this comment

drishtipeshwani09 commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading

openapi-pipeline-app bot commented May 3, 2024 •

edited

Loading