Add possibility to create EventHub namespace with kafka #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @thamer-ea ! |
lmazuel
reviewed
Apr 27, 2019
| /** | ||
| * @return true if kafka enabled for the namespace, false otherwise | ||
| */ | ||
| @Beta(Beta.SinceVersion.V1_7_0) |
praries880
reviewed
Apr 29, 2019
| /** | ||
| * Properties of kafka resource. | ||
| */ | ||
| @JsonProperty(value = "kafkaEnabled") |
There was a problem hiding this comment.
@thamer-ea
did you hand edit this file to add the property to the inner?
praries880
reviewed
Apr 29, 2019
|
|
||
| Assert.assertNotNull(namespace); | ||
| Assert.assertNotNull(namespace.inner()); | ||
| Assert.assertFalse(namespace.isKafkaEnabled()); |
There was a problem hiding this comment.
@thamer-ea
As of now the tests are failing with this assertion... Kafka Enabled seems to be false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to resolve #548