Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB#29764273 [Configuration]Disable optional interactive user for http 20 or min tls version 1.3 #7917

Merged
merged 3 commits into from
Nov 25, 2024
Merged

AB#29764273 [Configuration]Disable optional interactive user for http 20 or min tls version 1.3 #7917

merged 3 commits into from
Nov 25, 2024

Conversation

liuqidake
Copy link
Contributor

@liuqidake liuqidake commented Nov 22, 2024 •
edited
Loading

Fixes: AB#29764273

  1. Change client cert mode value to reflect the underlying value to avoid any confusion:

Before: Optional -> Allow, OptionalInteractiveUser -> Optinal
Now: Optional -> Optional, OptionalInteractiveUser -> Optional Interactive User

  1. Disable optional interactive user if http version is 2 and the min TLS version is 1.3. If the currently selected mode is optional interactive user, then switch it to ignore. A warning message is shown to explains why optional interactive user is disabled

image
image

@liuqidake liuqidake changed the title [Configuration]Disable optional interactive user for http 20 or min tls version 1.3 AB#29764273 [Configuration]Disable optional interactive user for http 20 or min tls version 1.3 Nov 22, 2024
@liuqidake liuqidake enabled auto-merge (squash) November 25, 2024 19:40
@liuqidake liuqidake merged commit 59ab759 into dev Nov 25, 2024
8 checks passed
@liuqidake liuqidake deleted the liuqi/mintlsVersionAndHttp20 branch November 25, 2024 19:47
shimedh pushed a commit that referenced this pull request Dec 3, 2024
@liuqidake @shimedh
AB#29764273 [Configuration]Disable optional interactive user for http…
9038559 
… 20 or min tls version 1.3 (#7917)

* disable optional interactive user for http 20 or min tls version 1.3

* update variable name

---------

Co-authored-by: Qi Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StewartMckenzie StewartMckenzie StewartMckenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuqidake @StewartMckenzie