Skip to content

Commit

Permalink
[DC] Remove environment from Node and Python FA workflow files (#7921)
Browse files Browse the repository at this point in the history
Co-authored-by: Yoona Oh <[email protected]>
  • Loading branch information
yoonaoh and johmsft authored Nov 25, 2024
1 parent ec99afe commit eaeef97
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -78,13 +78,13 @@ const DeploymentCenterCodeSettings: React.FC<DeploymentCenterFieldProps<Deployme
const [isVstsSetup, setIsVstsSetup] = useState(false);
const [isTfsOrVsoSetup, setIsTfsOrVsoSetup] = useState(false);
const [isUsingExistingOrAvailableWorkflowConfig, setIsUsingExistingOrAvailableWorkflowConfig] = useState(false);
const [isRemoveEnvEnabled, setIsRemoveEnvEnabled] = useState(false);
const [isRemoveEnvWebAppEnabled, setIsRemoveEnvWebAppEnabled] = useState(false);
useEffect(() => {
let isSubscribed = true;

portalContext?.getBooleanFlight(ExperimentationConstants.FlightVariable.removeDeployEnvironment).then(hasFlightEnabled => {
portalContext?.getBooleanFlight(ExperimentationConstants.FlightVariable.removeDeployEnvironmentWebApp).then(hasFlightEnabled => {
if (isSubscribed) {
setIsRemoveEnvEnabled(hasFlightEnabled);
setIsRemoveEnvWebAppEnabled(hasFlightEnabled);
}
});

Expand Down Expand Up @@ -169,7 +169,7 @@ const DeploymentCenterCodeSettings: React.FC<DeploymentCenterFieldProps<Deployme
variables['javaContainer'] = formProps.values.javaContainer;
}

if (isRemoveEnvEnabled) {
if (isRemoveEnvWebAppEnabled) {
variables['isRemoveEnvEnabled'] = true;
}

Expand Down
1 change: 0 additions & 1 deletion client-react/src/utils/CommonConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,6 @@ export class ExperimentationConstants {
};

public static FlightVariable = {
removeDeployEnvironment: 'remove-deploy-environment',
removeDeployEnvironmentWebApp: 'remove-deploy-environment-webapp',
enableSidecarMigration: 'enable-sidecar-migration',
showDCReactView: 'show-dc-reactview',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ jobs:
deploy:
runs-on: ubuntu-latest
needs: build
__environment__
__permissions__
steps:
- name: Download artifact from build job
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
deploy:
runs-on: windows-latest
needs: build
__environment__
__permissions__
steps:
- name: Download artifact from build job
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
deploy:
runs-on: ubuntu-latest
needs: build
__environment__
__permissions__
steps:
- name: Download artifact from build job
Expand Down

0 comments on commit eaeef97

Please sign in to comment.