Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3776 - Latest version reports it is old #4204

Closed

Conversation

VineethReyya
Copy link
Contributor

Issue describing the changes in this PR

when we install Azure Function Core Tool via chocolatey, the shim is generating twice as we have 3.exe files (in root folder inproc6 and inproc8 folder). we have removed -recurse from installation script as its looking into subfolders(inproc6, inproc8) for the .exe file. Removing -recurse will now only look into files from root directory
resolves #3776

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@VineethReyya
Copy link
Contributor Author

VineethReyya commented Nov 26, 2024

Hi @kshyju @aishwaryabh made changes to look only into root directory when installing from choco.

Now we are getting this issue even installing via windows for the current version. Looking at the download links for the coretool tool for current and previous version.
current version release number: there is difference in CoreToolsReleaseNumber and assembly version
coretoolReleaseNumberMismatch

Previous version : there is no difference in releasenumber and assembly version
image

Current Assembly version of installed coretool via windows:
image

could you review the changes when you have moment of time.

Thanks.

@aishwaryabh
Copy link
Contributor

Hey @VineethReyya , yes these changes are expected. The core tools release number and assembly versions are different now with the latest changes for supporting the default host. You would have to make sure that the CDN link is updated such that we parse both the core tools release version and assembly version.

@aishwaryabh
Copy link
Contributor

Can you have the target branch be main now?

@fabiocav fabiocav changed the base branch from feature/oop-host to main November 26, 2024 18:47
@fabiocav fabiocav requested a review from a team as a code owner November 26, 2024 18:47
@fabiocav fabiocav changed the base branch from main to feature/oop-host November 26, 2024 18:47
@VineethReyya VineethReyya changed the base branch from feature/oop-host to main November 27, 2024 04:46
@VineethReyya VineethReyya changed the base branch from main to feature/oop-host November 27, 2024 04:47
@VineethReyya
Copy link
Contributor Author

Can you have the target branch be main now?

@aishwaryabh Could you review PR changes( targeted to main branch) ⁠and also help me out to get the updated CDN link for the release data. ( current release data ⁠CDN Link).

Thanks.

@VineethReyya
Copy link
Contributor Author

created new PR. Hence closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants