Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebasing v4.x #4202

Closed
wants to merge 17 commits into from
Closed

Rebasing v4.x #4202

wants to merge 17 commits into from

Conversation

aishwaryabh
Copy link
Contributor

Issue describing the changes in this PR

Rebasing v4.x

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

jviau and others added 17 commits November 6, 2024 11:20
* Set the default PowerShell worker to 7.4

---------

Co-authored-by: Matthew Henderson <[email protected]>
* this doesn't work

* this finally works now

* default should be oop host

* added edge cases

* fixing formatting

* using determineTargetFramework

* saving tests

* adding copy step for OOP

* fixing the webhost reference

* removing test

* setting host version in ps script

* update to validate worker versions script

* update versions for worker packages

* adding ToString

* validating worker version

* validate worker versions

* updating csproj to compile

* addressing pr feedback

* updating build steps

* adding build step

* fixing build step

* trying to get this working

* reverrting target runtimes

* updating tests

* adding dotnet info step

* adding changes

* removing extra test

* trying to specify architecture

* modifying tests to see if they work

* narrowing down to tests that are failing

* trying to see if it works with nobuild flag

* addressing pr feedback

* updating tests with latest logging

* addressing comments and marking flaky tests

* updating so that we are only using net8 framework

* pushing change for branch build

* adding single quotes

* reverting quotes

* adding code mirror fiile

* updating build step

* updatinng build steps

* updating build step

* adding step for dotnet publish

* set inprochost compilation system to diff value and skip flaky test

* updating public build pipeline to trigger

* adding extra changes for pipeline

* public build yml

* updating official build

* readd net8 build artifact step

* readding space back

* addressing initial comments

* adding explicit openTelemetry dlls

* simplifying logic of startHostAction

* addressing PR feedback

* start tests

* changing some of the tests back

* reverting test back to normal

* fixing spacing for csproj

* addressing PR feedback

* adding extra variable

* adding logic for edge case scenarios

* added edge cases tests

* removing extra line in node

* addressing comments

* moving validate host runtime to its own method

* forgot to add return statement
* this doesn't work

* this finally works now

* default should be oop host

* added edge cases

* fixing formatting

* using determineTargetFramework

* saving tests

* adding copy step for OOP

* fixing the webhost reference

* removing test

* setting host version in ps script

* update to validate worker versions script

* update versions for worker packages

* adding ToString

* validating worker version

* validate worker versions

* updating csproj to compile

* addressing pr feedback

* updating build steps

* adding build step

* fixing build step

* trying to get this working

* reverrting target runtimes

* updating tests

* adding dotnet info step

* adding changes

* removing extra test

* trying to specify architecture

* modifying tests to see if they work

* narrowing down to tests that are failing

* trying to see if it works with nobuild flag

* addressing pr feedback

* updating tests with latest logging

* addressing comments and marking flaky tests

* updating so that we are only using net8 framework

* pushing change for branch build

* adding single quotes

* reverting quotes

* adding code mirror fiile

* updating build step

* updatinng build steps

* updating build step

* adding step for dotnet publish

* set inprochost compilation system to diff value and skip flaky test

* updating public build pipeline to trigger

* adding extra changes for pipeline

* public build yml

* updating official build

* readd net8 build artifact step

* readding space back

* addressing initial comments

* adding explicit openTelemetry dlls

* simplifying logic of startHostAction

* addressing PR feedback

* start tests

* changing some of the tests back

* reverting test back to normal

* fixing spacing for csproj

* addressing PR feedback

* adding extra variable

* adding logic for edge case scenarios

* added edge cases tests

* initial changes

* removing extra line in node

* removing files not needed for custom host

* adding build steps

* addressing comments

* moving validate host runtime to its own method

* forgot to add return statement

* trying out creating directory

* remove skip artifact gen

* updating build step

* updating build to include in official pipeline

* updating publishing custom host step

* code mirror

* trying to get official build working

* program cs update

* updating custom host to work with parsing local.settings.json

* console read line for stalling process

* removing changes not needed for custom host

* only including inproc6 and inproc8 changes

* addressing initial comments

* removing skip artifact gen flag

* verbose logging

* tryna add release pipeline

* windows yaml changes

* addressing comments about yml

* updating log message

* fixing spacing

* fixing spacing again

* trying spacing again

* spacing change

* tryan fix spacing this way

* spacing

* spacing

* new line

* regular indentation

* super indent

* changing spacing back to normal

* addressing comments

* fixing pipeline
* build steps

* trying to parallelize build steps

* Revert "build steps"

This reverts commit 9aa82fa.

* Reapply "build steps"

This reverts commit a7b7d46.

* Revert "trying to parallelize build steps"

This reverts commit d10ef5c.
…roduce the package (#3843)

* Adding artifact assembler program which collects artifacts from different sources and assemble the final package for core tools.

* Adding README

* Remove downloaded artifact directories. Minor language update to README
* assemble artifacts

* adding code mirror to test

* try awaiting tasks to save space

* removing --net8 dependency

* trying to delete directory one at a time

* trying again with extracting

* diff build steps for vs and cli

* forgot to include other step for var

* trying out new changes

* clean up each zip file after extracting

* trying another approach

* try to delete each directory after copying

* removing logic for creating zips rn

* including e2e test changes and add powershell file

* removing multi targeting

* pass in staging directory

* adding param

* adding logging

* printing out paths

* adding isolated e2e tests and changing verbosity for logger

* adding a new label

* comments

* adding more clarifying comments

* removing extra test and types

* adding logging statement for failing task if we fail tests

* updating tests to only run in winx64 and winx86

* target directory

* target directory

* changes to msi file

* print out directory

* resolving path

* reorg files and try to set env variable

* dont delete artifacts

* update generate msi files

* add doller sign for variable name and fix e2e test

* changing runtime version

* updating to get correct cli version

* lol forgot to have content in zip ps script

* Update src/Azure.Functions.ArtifactAssembler/ArtifactAssembler.cs

Co-authored-by: Lilian Kasem <[email protected]>

* Update src/Azure.Functions.ArtifactAssembler/ArtifactAssembler.cs

Co-authored-by: Lilian Kasem <[email protected]>

* Update src/Azure.Functions.ArtifactAssembler/ArtifactAssembler.cs

Co-authored-by: Lilian Kasem <[email protected]>

* Update src/Azure.Functions.ArtifactAssembler/ArtifactAssembler.cs

Co-authored-by: Lilian Kasem <[email protected]>

* Update src/Azure.Functions.ArtifactAssembler/ArtifactAssembler.cs

Co-authored-by: Lilian Kasem <[email protected]>

* addressing comments

* reverting programcs back to the way it was

* staging directory not correct

* merging

* Revert "merging"

This reverts commit 89cc110.

* fixing spacing

* wrong directory

* trying to free up disk space

* removing custom code mirror

* removing dollar signs

* updating build number

* adding variables back

* fix build number

* fixing candle

* fixing msi files

* reverting files back to normal

---------

Co-authored-by: Lilian Kasem <[email protected]>
* adding system.text.json

* update patch

* move to 8.0.10

* fixing indentation

* trying to change version
…ine (#3884)

* adding generate metadata file

* remove code mirror

* get correct inproc version

* print out metadata file

* fixing zip issue

* fixing release number

* fixing release number again

* removing zip artifact script and fixing code mirror
@aishwaryabh aishwaryabh requested review from a team as code owners November 25, 2024 20:04
Copy link

Dependency Review

The following issues were found:
  • ❌ 1 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 4 package(s) with unknown licenses.
  • ⚠️ 1 packages with OpenSSF Scorecard issues.
See the Details below.

Vulnerabilities

src/Azure.Functions.Cli/Azure.Functions.Cli.csproj

NameVersionVulnerabilitySeverity
DotNetZip1.16.0DotNetZip Directory Traversal vulnerabilityhigh

License Issues

src/Azure.Functions.Cli/Azure.Functions.Cli.csproj

PackageVersionLicenseIssue Type
Microsoft.Azure.Functions.JavaWorker2.16.0NullUnknown License
Microsoft.Azure.Functions.PowerShellWorker.PS7.24.0.4020NullUnknown License
Microsoft.Azure.Functions.PowerShellWorker.PS7.44.0.4021NullUnknown License
Microsoft.Azure.Functions.PythonWorker4.31.0NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
nuget/Microsoft.NETCore.DotNetAppHost 8.0.8 🟢 5.5
Details
CheckScoreReason
Code-Review🟢 10all changesets reviewed
Packaging⚠️ -1packaging workflow not detected
Maintained🟢 1030 commit(s) and 21 issue activity found in the last 90 days -- score normalized to 10
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
License🟢 10license file detected
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Security-Policy🟢 10security policy file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection🟢 8branch protection is not maximal on development and all release branches
Fuzzing⚠️ 0project is not fuzzed
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
Binary-Artifacts⚠️ 0binaries present in source code
Vulnerabilities🟢 73 existing vulnerabilities detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
nuget/DotNetZip 1.16.0 ⚠️ 1.3
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 4Found 8/17 approved changesets -- score normalized to 4
Maintained⚠️ 0project is archived
Dangerous-Workflow⚠️ -1no workflows found
Token-Permissions⚠️ -1No tokens found
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 3binaries present in source code
Security-Policy⚠️ 0security policy file not detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 9license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ 0branch protection not enabled on development/release branches
Pinned-Dependencies⚠️ -1no dependencies found
Vulnerabilities⚠️ 021 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0
nuget/Microsoft.Azure.Functions.JavaWorker 2.16.0 UnknownUnknown
nuget/Microsoft.Azure.Functions.PowerShellWorker.PS7.2 4.0.4020 UnknownUnknown
nuget/Microsoft.Azure.Functions.PowerShellWorker.PS7.4 4.0.4021 UnknownUnknown
nuget/Microsoft.Azure.Functions.PythonWorker 4.31.0 UnknownUnknown
nuget/Microsoft.Azure.WebJobs.Script.WebHost 4.1036.1 🟢 5.5
Details
CheckScoreReason
Maintained🟢 1030 commit(s) and 13 issue activity found in the last 90 days -- score normalized to 10
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 9Found 29/30 approved changesets -- score normalized to 9
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Security-Policy🟢 10security policy file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Binary-Artifacts🟢 6binaries present in source code
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Pinned-Dependencies⚠️ 0dependency not pinned by hash detected -- score normalized to 0
Signed-Releases⚠️ 0Project has not signed or included provenance with any releases.
Branch-Protection⚠️ -1internal error: error during GetBranch(release/in-proc-hotfix-v4.36.3-option2): error during branchesHandler.query: internal error: githubv4.Query: Resource not accessible by integration
Vulnerabilities🟢 100 existing vulnerabilities detected
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • host/src/CoreToolsHost/CoreToolsHost.csproj
  • src/Azure.Functions.Cli/Azure.Functions.Cli.csproj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants