Custom Host For Linux #4152
Merged
Custom Host For Linux #4152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
Nov 7, 2024
kshyju
reviewed
Nov 7, 2024
kshyju
reviewed
Nov 7, 2024
kshyju
reviewed
Nov 7, 2024
| @@ -1426,7 +1426,7 @@ await CliTester.Run(new RunConfiguration[] | |||
| }, _output); | |||
| } | |||
|
|
|||
| [Theory] | |||
| [Theory(Skip = "Test is flakey")] | |||
There was a problem hiding this comment.
Let's capture this test name somewhere (may be in a GH issue) so that we can come back and address it with other flaky tests.
kshyju
approved these changes
Nov 7, 2024
aishwaryabh
added a commit
that referenced
this pull request
Nov 26, 2024
* addressing comments and initial changes for generating artifacts * osx change * deleting extra directory * change order of extract directories * logging artifact directory * skipping flakey e2e test * fixed version bug * addressing comments * core tools host windows should still sign * adding exe to comment * removing self-contained arg * addding logging statement * adding assembly path logging * removing not needed nethost logging * more logging! * adding signing back * removing sign step * adding path var * adding variable to path * install net8 * seperating net9 task to seperate job * forgot quote * add core tools host * adding mac signing * changing mac folder back * changing signing path back * trying 3rd party sign * trying to notarize * remove custom host mac * removing not needed logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #3886
This PR creates a custom host for linux. This was tested locally on a docker container and the artifacts are also signed.
For mac, we are currently blocked as the signing does not work and there were some issues locally for repro'ing this, so I modified this PR just to include the linux changes.
Note that this was the initial PR but rebasing got way too messy so just created a new one.
Pull request checklist