Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When local.settings.json is absent, runnig func host start does not work for newer worker models #3544 (Refreshed Branch Changes) #4142

Merged

Conversation

VineethReyya
Copy link
Contributor

Issue describing the changes in this PR

-> when local.settings.json is absent.
Scenario1: running 'func host start' will Display Available WorkerRuntime on the screen and user can select the Runtime from the list so the FUNCTION_WORKER_RUNTIME setting is added and start hosting the function app
Scenario2: running 'func host start --{WorkerRuntime}' will add FUNCTION_WORKER_RUNTIME setting and start hosting the function app.
resolves #3544

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@VineethReyya VineethReyya requested a review from a team as a code owner November 4, 2024 12:55
@VineethReyya VineethReyya changed the title When local.settings.json is absent, runnig func host start does not work for newer worker models #3544 (Refreshed Branch Changes)) When local.settings.json is absent, runnig func host start does not work for newer worker models #3544 (Refreshed Branch Changes) Nov 4, 2024
@VineethReyya
Copy link
Contributor Author

Issue describing the changes in this PR

-> when local.settings.json is absent. Scenario1: running 'func host start' will Display Available WorkerRuntime on the screen and user can select the Runtime from the list so the FUNCTION_WORKER_RUNTIME setting is added and start hosting the function app Scenario2: running 'func host start --{WorkerRuntime}' will add FUNCTION_WORKER_RUNTIME setting and start hosting the function app. resolves #3544

Pull request checklist

  • My changes do not require documentation changes

    • Otherwise: Documentation issue linked to PR
  • My changes do not need to be backported to a previous version

    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@liliankasem PR was failed to build in azure pipeline. after looking into the reason for failure I came to know that you have worked on starttest.cs. Now I refreshed my branch with latest changes and created a new PR. could you please review when you have free moment of time.

@liliankasem liliankasem merged commit 065ff4c into v4.x Nov 5, 2024
10 checks passed
@liliankasem liliankasem deleted the 3544-localsettingsjson-is-absent-runnig-func-host-start branch November 5, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When local.settings.json is absent, runnig func host start does not work for newer worker models
2 participants