Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Chat With your Data #354

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Adding Chat With your Data #354

merged 2 commits into from
Apr 10, 2024

Conversation

ross-p-smith
Copy link
Contributor

Please fill out this template! There are three different types of contributions, feel free to delete the checklists that are not applicable to your contribution type.

If you are submitting a new azd template to the gallery

Fill this out if you want your template to be added to the awesome-azd gallery!

Your template repository

Place your template repository link here: https://github.com/Azure-Samples/chat-with-your-data-solution-accelerator

  • Added an entry to https://github.com/Azure/awesome-azd/blob/main/website/src/data/users.tsx that includes:

    • Template title - A short title that reflects the local application stack that someone could use to get their application on Azure (e.g. "Containerized React Web App with Java API and MongoDB")

    • Description - 1-2 sentence description of the architecture (e.g. Azure services) or solution that is defined by the template.

    • Architecture Diagram or Application Screenshot - The image should include all services and their connections (example). You should add the image to the website/src/data/images/.

    • Link to Author's GitHub or other relevant website - Used for attribution

    • Author's Name - Name to credit on the gallery card

    • Link to template source - Link to the template GitHub repo

    • Tags - Specify tags to represent the template. If you don't see a relevant tag for your template? Feel free to add one!

      Required tags:

      • Tag your template as Micrsoft-authored ("msft") or Community-authored ("community")
      • Tag the IaC provider ("bicep" or "terraform")
      • At least 1 tag for programming language used
      • At least 1 tag for Azure services integrated
      • Add the "new" tag for any newly authored templates
  • In the PR comment, if you can also add a link to the PR where you made your repo azd compatible this will allow us to provide feedback on your template and speed up the review process.

If you are submitting a resource to be added to the awesome-azd README:

  • Name of resource
  • Resource author - who created this resource? (so we can credit them!)
  • What section should this resource be included in? -Is the resource an article? A video? Something else?

@ross-p-smith
Copy link
Contributor Author

The current .devcontainer.json will not automatically open in vscode as it should not be prefixed with a .

I also wonder why this devcontainer has docker-in-docker configured? You are not using docker for anything that I can see

@hemarina
Copy link
Contributor

hemarina commented Apr 9, 2024

@ross-p-smith Thanks for the suggestions. We were using devcontainer for codespace support and haven't been use it for a while. We will update devcontainer.json, like removing unused docker-in-docker in features. Tracking it in #355.

@zedy-wj Could you test this template?

@zedy-wj
Copy link
Member

zedy-wj commented Apr 10, 2024

@hemarina - We tested this template according to it's README and everything works fine.

Copy link
Contributor

@hemarina hemarina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hemarina hemarina merged commit 9a4acda into Azure:main Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants