-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump http-client-python 0.5.0 #2981
base: main
Are you sure you want to change the base?
Conversation
98ea180
to
37626dc
Compare
coverage==7.6.1 | ||
black==24.8.0 | ||
ptvsd==4.3.2 | ||
types-PyYAML==6.0.12.8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file shall be synced with https://github.com/microsoft/typespec/blob/main/packages/http-client-python/generator/dev_requirements.txt
coverage==7.6.9 | ||
black==24.10.0 | ||
setuptools==73.0.1 | ||
-r ../packages/typespec-python/dev_requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although it is a little weird to install dependencies of subdirectory, we only need to update dependencies in one file after this change which is easier to maintain in the future.
pyright==1.1.391 | ||
pylint==3.2.7 | ||
tox==4.23.2 | ||
mypy==1.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eng is only needed by pipeline for development, so there is no need to keep 2 files that requirements.txt and dev_requirements.txt, then I combined them into 1 file: dev_requirements.txt
.
MarkupSafe==2.1.2 | ||
mistune==0.8.4 | ||
pathspec==0.11.1 | ||
platformdirs==3.2.0 | ||
PyYAML==6.0.1 | ||
tomli==2.0.1 | ||
setuptools==69.2.0 | ||
json-rpc==1.14.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed dependencies are already declared in pygen.
@@ -95,8 +95,8 @@ | |||
"operation_group_one": "OperationGroupOneOperations" | |||
}, | |||
"operation_mixins": { | |||
"sync_imports": "{\"conditional\": {\"stdlib\": {\"typing\": [\"Any\", \"Iterable\"]}}, \"regular\": {\"stdlib\": {\"typing\": [\"IO\", \"Iterator\", \"Optional\", \"Union\"], \"io\": [\"IOBase\"]}, \"local\": {\".\": [[\"models\", \"_models\"]]}, \"sdkcore\": {\"azure.core.polling\": [\"LROPoller\"], \"azure.core.paging\": [\"ItemPaged\"]}}}", | |||
"async_imports": "{\"conditional\": {\"stdlib\": {\"typing\": [\"Any\", \"AsyncIterable\"]}}, \"regular\": {\"stdlib\": {\"typing\": [\"AsyncIterator\", \"IO\", \"Optional\", \"Union\"], \"io\": [\"IOBase\"]}, \"local\": {\"..\": [[\"models\", \"_models\"]]}, \"sdkcore\": {\"azure.core.polling\": [\"AsyncLROPoller\"], \"azure.core.async_paging\": [\"AsyncItemPaged\"]}}}", | |||
"sync_imports": "{\"conditional\": {\"stdlib\": {\"typing\": [\"Any\", \"Iterable\"]}}, \"regular\": {\"stdlib\": {\"typing\": [\"IO\", \"Iterator\", \"Optional\", \"Union\"], \"io\": [\"IOBase\"]}, \"sdkcore\": {\"azure.core.polling\": [\"LROPoller\"], \"azure.core.paging\": [\"ItemPaged\"]}, \"local\": {\".\": [[\"models\", \"_models\"]]}}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After pyodide PR merged, there is a little diff in generated code but all of diffs don't cause real issue.
@@ -9,15 +9,15 @@ ignore=_generated,samples,examples,test,tests,doc,.tox,generated_samples | |||
[MESSAGES CONTROL] | |||
|
|||
# Add enable for useless disables | |||
enable=useless-suppression | |||
# enable=useless-suppression |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fix the CI to enable pylint for autorest.python then some tiny lint issues are reporeted. I disable some specific items and we could fix them in another PR.
No description provided.