Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Change Azure AD refs to Microsoft Entra #204

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

ibersanoMS
Copy link
Contributor

@ibersanoMS ibersanoMS commented Feb 22, 2024

Description

  • Updated variable names and refs from Azure AD and it's variants to Microsoft Entra or Entra for short
  • Updated documentation references from Azure AD to Microsoft Entra
  • Fixed spelling errors

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Copy link

Terraform Plan failed

Plan Error Output


Error: Error ensuring Resource Providers are registered.

Terraform automatically attempts to register the Resource Providers it supports to
ensure it's able to provision resources.

If you don't have permission to register Resource Providers you may wish to use the
"skip_provider_registration" flag in the Provider block to disable this functionality.

Please note that if you opt out of Resource Provider Registration and Terraform tries
to provision a resource from a Resource Provider which is unregistered, then the errors
may appear misleading - for example:

> API version 2019-XX-XX was not found for Microsoft.Foo

Could indicate either that the Resource Provider "Microsoft.Foo" requires registration,
but this could also indicate that this Azure Region doesn't support this API version.

More information on the "skip_provider_registration" flag can be found here:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration

Original Error: Cannot register providers: Microsoft.SignalRService, Microsoft.DataFactory. Errors were: Cannot register provider Microsoft.SignalRService with Azure Resource Manager: unexpected status 403 with error: AuthorizationFailed: The client '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' with object id '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' does not have authorization to perform action 'Microsoft.SignalRService/register/action' over scope '/subscriptions/864eb9d0-e9c4-4d6b-bf11-bd4cfde05e81' or the scope is invalid. If access was recently granted, please refresh your credentials..
Cannot register provider Microsoft.DataFactory with Azure Resource Manager: unexpected status 403 with error: AuthorizationFailed: The client '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' with object id '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' does not have authorization to perform action 'Microsoft.DataFactory/register/action' over scope '/subscriptions/864eb9d0-e9c4-4d6b-bf11-bd4cfde05e81' or the scope is invalid. If access was recently granted, please refresh your credentials..

  with provider["registry.terraform.io/hashicorp/azurerm"],
  on main.tf line 17, in provider "azurerm":
  17: provider "azurerm" {


Pusher: @ibersanoMS, Action: pull_request, Working Directory: scenarios/secure-baseline-multitenant/terraform/hub, Workflow: Scenario 1: Terraform Multi-Tenant ASEv3 Secure Baseline

Copy link

Terraform Plan failed

Plan Error Output


Error: Error ensuring Resource Providers are registered.

Terraform automatically attempts to register the Resource Providers it supports to
ensure it's able to provision resources.

If you don't have permission to register Resource Providers you may wish to use the
"skip_provider_registration" flag in the Provider block to disable this functionality.

Please note that if you opt out of Resource Provider Registration and Terraform tries
to provision a resource from a Resource Provider which is unregistered, then the errors
may appear misleading - for example:

> API version 2019-XX-XX was not found for Microsoft.Foo

Could indicate either that the Resource Provider "Microsoft.Foo" requires registration,
but this could also indicate that this Azure Region doesn't support this API version.

More information on the "skip_provider_registration" flag can be found here:
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs#skip_provider_registration

Original Error: Cannot register providers: Microsoft.SignalRService, Microsoft.DataFactory. Errors were: Cannot register provider Microsoft.SignalRService with Azure Resource Manager: unexpected status 403 with error: AuthorizationFailed: The client '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' with object id '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' does not have authorization to perform action 'Microsoft.SignalRService/register/action' over scope '/subscriptions/864eb9d0-e9c4-4d6b-bf11-bd4cfde05e81' or the scope is invalid. If access was recently granted, please refresh your credentials..
Cannot register provider Microsoft.DataFactory with Azure Resource Manager: unexpected status 403 with error: AuthorizationFailed: The client '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' with object id '6f1b60ca-5362-4f06-bc90-0ab4bb178f8a' does not have authorization to perform action 'Microsoft.DataFactory/register/action' over scope '/subscriptions/864eb9d0-e9c4-4d6b-bf11-bd4cfde05e81' or the scope is invalid. If access was recently granted, please refresh your credentials..

  with provider["registry.terraform.io/hashicorp/azurerm"],
  on main.tf line 17, in provider "azurerm":
  17: provider "azurerm" {


Pusher: @ibersanoMS, Action: pull_request, Working Directory: scenarios/secure-baseline-multitenant/terraform/hub, Workflow: Scenario 1: Terraform Multi-Tenant ASEv3 Secure Baseline

@ibersanoMS ibersanoMS linked an issue Mar 12, 2024 that may be closed by this pull request
Copy link
Contributor

@kunalbabre kunalbabre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@kunalbabre kunalbabre merged commit f466017 into main Mar 19, 2024
7 of 8 checks passed
@kunalbabre kunalbabre deleted the chore/change-aad-refs-to-entra branch March 19, 2024 16:09
jonlester pushed a commit that referenced this pull request May 20, 2024
* chore: update aad refs in TF files and readmes

* chore: update bicep and arm files with entra

* docs: update tf docs using pre-commit
ibersanoMS added a commit that referenced this pull request Oct 1, 2024
* chore: update aad refs in TF files and readmes

* chore: update bicep and arm files with entra

* docs: update tf docs using pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update references from Azure AD to Entra
2 participants