-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added OpenAI module to multitenant spoke deployment #190
Conversation
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
We have that in the documentation we need it for tfvars, to connect to existing hub
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some minor changes in the documentation.
Two strange changes I needed to do, other wise the deployment was failing:
- In file spoke/variables.tf the variable "hub_settings" was commented. I needed to uncomment
- in file [/terraform/spoke/shared.tf] I had to change the value vm_subnet_id = module.network.subnets[index(module.network.subnets.*.name, "devops")].id to the simpler vm_subnet_id = module.network.subnets["devops"].id
Other than that, all looks good
* Added AI module to multitenant spoke * OpenAI module added to multitenant scenario with private networking config. * fixing bug with repeat go_version definition on appsvc_options * fix: variable hub_settings We have that in the documentation we need it for tfvars, to connect to existing hub * fixed something that didn't work for me --------- Co-authored-by: Thodoris Theodorou <[email protected]>
* Added AI module to multitenant spoke * OpenAI module added to multitenant scenario with private networking config. * fixing bug with repeat go_version definition on appsvc_options * fix: variable hub_settings We have that in the documentation we need it for tfvars, to connect to existing hub * fixed something that didn't work for me --------- Co-authored-by: Thodoris Theodorou <[email protected]>
Description
#175
Added OpenAI module code to
terraform-modules/cognitive-services/openai
Currently added the deployment config on the Multi-tenant spoke scenario @ scenarios/secure-baseline-multitenant/terraform/spoke/ai.tf
The Secure-Baseline-ASE scenario currently has some networking configs that are missing, will look into addressing this by consolidating both scenarios into a single Terraform deployment (Issue #189)
Type of Change
Please delete options that are not relevant.
Checklist