Feature/terraform refactor for Scenarios 1 and 2 #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
…dom password for vm and store in Key Vault
Terraform Plan failedPlan Error OutputPusher: @JinLee794, Action: |
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Plan failedPlan Error OutputPusher: @JinLee794, Action: |
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
ibersanoMS
approved these changes
Aug 9, 2023
| owner = "[email protected]" | ||
|
|
||
| vm_aad_admin_object_id = "bda41c64-1493-4d8d-b4b5-7135159d4884" # "AppSvcLZA Azure AD SQL Admins" |
There was a problem hiding this comment.
Should this be hard coded here? I'm assuming this corresponds to a group created pre-deployment
| run: terraform validate -no-color | ||
| run: | | ||
| terraform validate -no-color | ||
| echo "::set-output name=stdout::$(terraform validate -no-color)" |
There was a problem hiding this comment.
set-output is deprecated. You'll need to do:
echo stdout=$(terraform validate -no-color) >> $GITHUB_OUTPUT
| } | ||
|
|
||
|
|
||
| # locals { |
There was a problem hiding this comment.
I would suggest removing any commented out code once you're committed to the module format
| } | ||
| variable "vm_aad_admin_object_id" { | ||
| type = string | ||
| description = "The Azure AD username for the VM admin account. If aad_admin_username is not specified, this value will be used." |
There was a problem hiding this comment.
Description needs review
|
|
||
| variable "vm_aad_admin_username" { | ||
| type = string | ||
| description = "[Optional] The Azure AD username for the VM admin account. If aad_admin_object_id is not specified, this value will be used." |
There was a problem hiding this comment.
Description needs review
| variable "location" { | ||
| type = string | ||
| description = "The Azure region where all resources in this example should be created" | ||
| default = "westeurope" |
| error_message = "Please, choose among one of the following operating systems: Windows or Linux." | ||
| } | ||
|
|
||
| # validation { |
| lower("${azurerm_windows_web_app.this.name}-${azurerm_windows_web_app_slot.slot.name}.scm") | ||
| ] | ||
|
|
||
| depends_on = [ |
There was a problem hiding this comment.
Dependency implied by ref above
| variable "location" { | ||
| type = string | ||
| description = "The Azure region where all resources in this example should be created" | ||
| default = "westeurope" |
| variable "location" { | ||
| type = string | ||
| description = "The Azure region where all resources in this example should be created" | ||
| default = "westeurope" |
…scenario 2 input param for location to westus2 from westus3
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
Terraform Format and Style 🖌``Terraform Initialization ⚙️
|
jonlester
pushed a commit
that referenced
this pull request
May 20, 2024
ibersanoMS
pushed a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#106
Pipeline references
Type of Change
Please delete options that are not relevant.
Checklist