Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bicep working state #97

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Bicep working state #97

merged 2 commits into from
Mar 15, 2024

Conversation

briggsb9
Copy link
Contributor

  • Improved naming to include instance number (01) according to naming best practice. Added parameter for this to allow easy redeploy and updated resourceSuffix in various places to avoid duplicates. Note: Keen to avoid unique string generation where possible due to messy names and recreation of existing resources.
  • Updated tag reference from construction set to LZ.
  • Update APIM management public IP DNS label to avoid naming errors. New Var introduced

Copy link
Contributor

@aarthiem aarthiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Ben, Thanks!

@aarthiem aarthiem merged commit 5036cfc into main Mar 15, 2024
2 of 3 checks passed
@briggsb9 briggsb9 deleted the bicep_working_state branch March 18, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants