Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make hub network optional #166

Merged
merged 9 commits into from
Oct 24, 2024
Merged

make hub network optional #166

merged 9 commits into from
Oct 24, 2024

Conversation

mosabami
Copy link
Contributor

@mosabami mosabami commented Oct 1, 2024

This PR is based on experience working with a customer. Customer wanted to create a POC environment but we had significant difficulty tuning this template to work for such a simple scenario. Here are the changes customers wanted to do that our template didnt enable:

  1. Not require a hub network
  2. Not use firewall
  3. Deploy successfully without providing hub resource id (we ran into issues with private network link)
  4. deploy template with at least 1 dedicated workload profile

Based on these requirements, this PR makes the following changes 

  1. Make it optional to deploy hub network
  2. Make it so that bastion can be deployed in spoke network but only if hub network is not deployed
  3. Only create egress lockdown (UDR) if a firewall is deployed
  4. Eliminate errors that occur when invalid hub resource ID is provided
  5. Add an option to enable non consumption workload profile
  6. Expose these new options to the deploy to Azure button method of deployment

@mosabami mosabami requested a review from a team as a code owner October 1, 2024 06:15
@mosabami mosabami requested review from kpantos and thotheod October 1, 2024 06:15
@mosabami mosabami changed the title make hub network and firewall optional make hub network optional Oct 1, 2024
@kpantos kpantos merged commit 1407ca0 into main Oct 24, 2024
10 of 13 checks passed
@kpantos kpantos deleted the mos-hub-optional branch October 24, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants