Add retry to check_sudo_status and unit test #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 92.09% 92.23% +0.14%
==========================================
Files 91 92 +1
Lines 15953 16035 +82
==========================================
+ Hits 14692 14790 +98
+ Misses 1261 1245 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
feng-j678
requested review from
kjohn-msft,
rane-rajasi and
najams
as code owners
kjohn-msft
reviewed
Nov 11, 2024
kjohn-msft
reviewed
Nov 11, 2024
kjohn-msft
reviewed
Nov 11, 2024
rane-rajasi
reviewed
Nov 12, 2024
rane-rajasi
reviewed
Nov 12, 2024
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
requested changes
Nov 19, 2024
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
changed the title
…into fix/check_sudo_status_failure resolve master branch conflicts.
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
reviewed
Nov 19, 2024
kjohn-msft
reviewed
Nov 19, 2024
feng-j678
force-pushed
the
fix/check_sudo_status_failure
branch
from
5bb6afc to
4060cc4
Compare
kjohn-msft
previously approved these changes
Nov 19, 2024
feng-j678
force-pushed
the
fix/check_sudo_status_failure
branch
from
3be69d9 to
ee36fa4
Compare
kjohn-msft
previously approved these changes
Nov 19, 2024
rane-rajasi
reviewed
Nov 20, 2024
kjohn-msft
reviewed
Nov 23, 2024
rane-rajasi
previously approved these changes
Nov 23, 2024
kjohn-msft
approved these changes
Nov 23, 2024
rane-rajasi
approved these changes
Nov 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] add retry logic into check_sudo_status that check sudo for 30 mins at interval of 5min (300sec)
[x] add MAX_CHECK_SUDO_RETRY_COUNT, MAX_CHECK_SUDO_INTERVAL_IN_SEC in constant
[x] add add unit test in test_coremain file to test all possible check sudo cases