Pr3/conditional checker #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile_component to load complete status
…into user/johnfeng/add_assessment_truncation
… map for performance optimization
…or performance issue
…n map in 2.7 are randomize
…nditional checker, and unit test
…into user/johnfeng/add_installation_truncation
…rm_truncation_if_needed
…UNCATION_IN_X_SEC = -1
feng-j678
requested review from
kjohn-msft,
rane-rajasi and
najams
as code owners
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
+ Coverage 90.39% 91.02% +0.63%
==========================================
Files 90 90
Lines 14810 15777 +967
==========================================
+ Hits 13387 14361 +974
+ Misses 1423 1416 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] add conditional checker to delay truncation to reduce truncation overhead - current time vs truncation timestamp if 60 secs have passed, truncation will execute. when timestamp is below 60 secs then truncation logic will not apply during application process unless the terminal state has reached (success or error).
[x] unit test