Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Cross referenced and added ARG queries #385

Merged
merged 36 commits into from
Apr 5, 2024
Merged

Cross referenced and added ARG queries #385

merged 36 commits into from
Apr 5, 2024

Conversation

humblejay
Copy link
Contributor

Overview/Summary

Cross references to VM and Storage ARGs, new query added

Related Issues/Work Items

AB#34153

This PR fixes/adds/changes/removes

  1. Cross reference SAP-1 to VM-2 ARG query
  2. Cross referenced SAP-15 to ST-1 ARG query
  3. Cross referenced SAP-9 to VM-8 ARG query
  4. Added SAP-8 Query
  5. Removed SAP-43

Breaking Changes

None

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries and/or scripts
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@humblejay humblejay requested a review from a team as a code owner March 22, 2024 02:55
@Dost2010 Dost2010 added Area: Service Guidance Improvements or additions to documentation Area: Resource Graph Query(s) labels Mar 24, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Mar 26, 2024

@humblejay please include a screenshot of the successful testing of the new query.

@humblejay
Copy link
Contributor Author

@humblejay please include a screenshot of the successful testing of the new query.

image

Copy link
Contributor

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @humblejay, these will be going away in APRL v2, but could you please revert the re-ordering of the recommendations, other teams reference the currently reference those IDs, so we cannot switch them.

Also, if there are existing Azure service recommendations, please reference them within the table instead of creating an SAP specific recommendation and using an existing query from an Azure resource. AVD and HPC can be used as a reference point for you.

@oZakari oZakari requested a review from Dost2010 April 2, 2024 15:54
@humblejay
Copy link
Contributor Author

humblejay commented Apr 3, 2024

Hey @humblejay, these will be going away in APRL v2, but could you please revert the re-ordering of the recommendations, other teams reference the currently reference those IDs, so we cannot switch them.

Also, if there are existing Azure service recommendations, please reference them within the table instead of creating an SAP specific recommendation and using an existing query from an Azure resource. AVD and HPC can be used as a reference point for you.

The numbering is reverted, some SAP recommendations have specific resources and language although they use the same queries from VM section (SAP 1,2,9). I am confirming with SAP team if it is okay to drop those.

@oZakari oZakari merged commit cf193d2 into Azure:main Apr 5, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Area: Resource Graph Query(s) Area: Service Guidance Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants