Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "repackage" goal to create fat jar #751

Merged

Conversation

rujche
Copy link
Contributor

@rujche rujche commented Aug 2, 2024

Purpose

To fix this problem:

$ java \
--module-path ./azure-security-keyvault-jca-2.8.2.jar \
--add-modules com.azure.security.keyvault.jca \
-Dsecurity.overridePropertiesFile=true \
-Djava.security.properties==./java.security \
-Dazure.keyvault.uri=xxx \
-Dazure.keyvault.tenant-id=xxx \
-Dazure.keyvault.client-id=xxx \
-Dazure.keyvault.client-secret=xxx \
-jar run-with-command-line-server-side-1.0.0.jar \
--server.port=8443 \
--server.ssl.enabled=true \
--server.ssl.key-alias=pfxchain \
--server.ssl.keystore-type=DKS \
--server.ssl.keyStoreProvider=AzureKeyVault \
--server.ssl.key-store=classpath:keyvault.dummy
no main manifest attribute, in run-with-command-line-server-side-1.0.0.jar

Does this introduce a breaking change?

[] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Just run the steps in https://github.com/Azure-Samples/azure-spring-boot-samples/blob/main/keyvault/azure-securtiy-keyvault-jca/run-with-command-line-server-side/README.md

What to Check

Verify that there is no error like no main manifest attribute, in run-with-command-line-server-side-1.0.0.jar.

Other Information

@rujche rujche requested a review from a team as a code owner August 2, 2024 05:57
saragluna
saragluna previously approved these changes Aug 2, 2024
@rujche
Copy link
Contributor Author

rujche commented Aug 3, 2024

/check-enforcer override

@rujche rujche closed this Aug 3, 2024
@rujche rujche reopened this Aug 3, 2024
…aintain because it doesn't exist anymore."

This reverts commit 4209443.
@rujche
Copy link
Contributor Author

rujche commented Aug 4, 2024

HI, @saragluna

  1. Please help to approve this PR again.
  2. The check failure is not cause by the change in this PR. We can fix it in another PR.

@rujche rujche merged commit a66e1ac into Azure-Samples:main Aug 8, 2024
5 of 7 checks passed
@rujche rujche deleted the add-repackage-goal-to-create-fat-jar branch August 8, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants