Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Azure AD to Microsoft Entra ID in non code section #729

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Rename Azure AD to Microsoft Entra ID in non code section #729

merged 1 commit into from
Oct 16, 2023

Conversation

moarychan
Copy link
Contributor

@moarychan moarychan commented Oct 9, 2023 •
edited
Loading

Purpose

Per the guidance at https://learn.microsoft.com/azure/active-directory/fundamentals/how-to-rename-azure-ad, rename Azure AD to Microsoft Entra ID for doc, not including the source source code change.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

Check the readme and annotations.

What to Check

Name change and link validation.

Other Information

@moarychan moarychan force-pushed the moary/sync-azure-ad--service-name branch from 3465a34 to 22071ad Compare October 10, 2023 05:17
Netyyyy
Netyyyy approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@Netyyyy Netyyyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@moarychan moarychan marked this pull request as ready for review October 12, 2023 06:31
@moarychan moarychan requested review from mrm9084 and a team as code owners October 12, 2023 06:31
@Netyyyy Netyyyy merged commit f58e7f4 into Azure-Samples:main Oct 16, 2023
7 of 8 checks passed
@moarychan moarychan mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Netyyyy Netyyyy Netyyyy approved these changes

@saragluna saragluna saragluna approved these changes

@mrm9084 mrm9084 Awaiting requested review from mrm9084 mrm9084 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moarychan @saragluna @Netyyyy