Allow users to configure instance identifiers #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, upon connection to AxonIQ Console, a random 4-letter string is assigned to make each client unique. Because the hostname can be the same for many clients (Especially in kubernetes). This works. However, it's better if the clients themselves define this identifier randomly. As statistics are saved under the instance name, they will duplicate if an instance disconnects and reconnects. By moving this random generation to the client, we will solve this problem.
CodeDrivenMitch
requested review from
corradom,
smcvb,
sandjelkovic and
stefanmirkovic
and removed request for
a team
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, upon connection to AxonIQ Console, a random 4-letter string is assigned to make each client unique. Because the hostname can be the same for many clients (Especially in kubernetes). This works.
However, it's better if the clients themselves define this identifier randomly. As statistics are saved under the instance name, they will duplicate if an instance disconnects and reconnects. By moving this random generation to the client, we will solve this problem.