Tests call signed_video_get_sei() before add for signing #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has a large impact on the tests. First, all tests streams have been increased with a 'P' to make sure that there is a NAL Unit to prepend a SEI with. Secondly, the SEIs are now delayed by one frame, which affects the validation statistics. In particular, all validations get a pending NAL Unit (the I-frame). Thirdly, since validation is triggered upon 2 I-frames, essentially all validations start with an unsigned GOP. Fixing this, will be done in a separate commit. The common test description has been updated with these changes. Further, almost all tests now have the same structure describing the validation flow.
bjornvolcker
requested review from
lusikamalo,
Caroline-Holmstrom and
mithydolphin
as code owners
mithydolphin
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a large impact on the tests. First, all tests streams have
been increased with a 'P' to make sure that there is a NAL Unit to
prepend a SEI with.
Secondly, the SEIs are now delayed by one frame, which affects the
validation statistics. In particular, all validations get a
pending NAL Unit (the I-frame).
Thirdly, since validation is triggered upon 2 I-frames, essentially
all validations start with an unsigned GOP. Fixing this, will be
done in a separate commit.
The common test description has been updated with these changes.
Further, almost all tests now have the same structure describing
the validation flow.