Changes description on when to use signed_video_get_sei(...) #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proper way is to call it BEFORE adding NAL Units for signing. Then the user can peek the next NAL Unit to get the SEI if and only if it can be prepended the peeked NAL Unit and at the same time follow the H.26x standard when using AU format. This commit only updates the description. Tests are updated separately.
bjornvolcker
requested review from
lusikamalo,
Caroline-Holmstrom and
mithydolphin
as code owners
mithydolphin
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proper way is to call it BEFORE adding NAL Units for signing. Then
the user can peek the next NAL Unit to get the SEI if and only if it
can be prepended the peeked NAL Unit and at the same time follow the
H.26x standard when using AU format.
This commit only updates the description. Tests are updated
separately.