Splits includes/signed_video_interfaces.h #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into a new public header file (signed_video_signing_plugin.h) with all new/renamed APIs to better reflect their usage. Further, moves the sign_algo_t and signature_info_t to signed_video_openssl.h since it is related to the cryptographic parts used by the wrappers in signed_video_openssl. All old APIs in signed_video_interfaces.h have been removed and the only remaining code is the redefinition of the plugin init/exit APIs. These need to be kept since they are not used by the library, but by the user.
bjornvolcker
requested review from
lusikamalo,
Caroline-Holmstrom and
mithydolphin
as code owners
mithydolphin
previously approved these changes
Apr 9, 2024
lusikamalo
reviewed
Apr 9, 2024
| * and output buffers. The thread is stopped if |out| is full, if there was a failure in | ||
| * the memory allocation for a new signature or if sv_interface_exit() is called. | ||
| * If the plugin is initialized, sv_signing_plugin_init(), one single central thread is spawned. | ||
| * Each Signed Video session will then get an id to distiguish between tehm since they use common |
lusikamalo
requested changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into a new public header file (signed_video_signing_plugin.h) with
all new/renamed APIs to better reflect their usage.
Further, moves the sign_algo_t and signature_info_t to
signed_video_openssl.h since it is related to the cryptographic
parts used by the wrappers in signed_video_openssl.
All old APIs in signed_video_interfaces.h have been removed and
the only remaining code is the redefinition of the plugin init/exit
APIs. These need to be kept since they are not used by the library,
but by the user.