chore: (#45) Fix failing java tests

[OT-kraftchain]

No description provided.

[mialbu]

Functionally everything looks good. 👍🏼

The main point I’d like to raise is that we generally avoid using wildcard imports, so I’d prefer if we use concrete imports instead. Other than that, I just have a few suggestions. Please take a look at my comments!

[mialbu]

The new format rules seem not to be applied to the contract class files GrantSharesGove.java and GrantSharesTreasury.java. Please apply it on these files as well.

suggestion: Also, consider removing WRAP_WHEN_TYPING_REACHES_RIGHT_MARGIN in the code style. This would keep long literal strings like the one in the @ContractSourceCode in a single string without having + operators to wrap it.

[mialbu]

suggestion: Also, consider removing WRAP_WHEN_TYPING_REACHES_RIGHT_MARGIN in the code style. This would keep long literal strings like the one in the @ContractSourceCode in a single string without having + operators to wrap it.

Maybe we should only do this in non-code files though. I renounce my suggestion.

[OT-kraftchain]

suggestion: Also, consider removing WRAP_WHEN_TYPING_REACHES_RIGHT_MARGIN in the code style. This would keep long literal strings like the one in the @ContractSourceCode in a single string without having + operators to wrap it.

Maybe we should only do this in non-code files though. I renounce my suggestion.

This doesn't seem to be doing what you expected. I set that to false and it's still wraping the string literals that are annotation parameters. I'll search for a different option

[mialbu]

This doesn't seem to be doing what you expected. I set that to false and it's still wraping the string literals that are annotation parameters. I'll search for a different option

Hmm, for me, with the line, it looks like this:

@ContractSourceCode(
        "https://github.com/AxLabs/grantshares-contracts/blob/main/src/main/java/com/axlabs/neo/grantshares" +
                "/GrantSharesGov.java")

and like this without it:

@ContractSourceCode(
        "https://github.com/AxLabs/grantshares-contracts/blob/main/src/main/java/com/axlabs/neo/grantshares/GrantSharesGov.java")

[OT-kraftchain]

yes, same for me, what I was saying is that even disabling that, it still formats it the same, breaking the string

[gsmachado]

@OT-kraftchain is this ready to merge?

[mialbu]

👌🏼