Add support for macOS (AppKit) using the NSUI package #29
Conversation
Directly derive PillView from UXView Add ability to specify a custom font to display the pill message Ensure pillView is centered within the container view Add ability to specify a different message when `completeTask` is called Comment out Hashable conformance because this is coming for free by dericing from UXView Rework initializer structure to use convenience init Fix issue where pillView was not removed from the view hierarchy when dismissed WIP: Add PillAnimation structure to allow pill to be animated from the bottom or from the top
Add extensions to NSUI
Derive PillBox directly from NSUIView instead of using containment Comment out Conformance as no longer needed Support AppKit for PillView transition Allow specification to sticky timeout for showError() Allow specification of a default Font for PillView Allow capability to update the showTask() message while in process Properly center the pillView into the container view using simple autoresizing masks Extend NSUIColor to get light and dark color scheme
…boxView into macos-appkit-with-nsui
… to help with AppKit / UIKit compatibility
…boxView into macos-appkit-with-nsui
|
sorry, just getting back from break. What's your plan with the "In-Process" (progress?) features. Do you want to finish those first or add those later? Since it seems so, I'll review this soon.. Thanks for the contributions! |
|
My primary objective was to send this PR early so you are OK with the direction and the inclusion of I will, hopefully, correct those this week and push more commits to complete the PR. |
|
Preview of the updated PillView working on iOS + Catalyst Let me know... |
… pillView heights Ensure font size does not exceed PillView height Rename files to start with Pill*
|
Don't hesitate to ping me if you need help with this PR review. |
|
Super. I will move forward with the PR that allows positioning the PillView either at the top or the bottom. That function is already working on my side. |
|
Sounds good. Maybe adding more padding to keep it inside safe areas would be nice. Thanks! |
|
I was thinking of adding the property And because a LMK. |
Here's my pull request to add AppKit support using NSUI.
Sorry this is a rather large PR.
I would be happy to discuss changes and modifications with you.
There are still some elements that are in process but I would rather submit it now and then continue moving forward after approval.
If you feel this is going too far from your original approach, let me know so we can collaborate and make this work.
I also updated the example
PillViewapp which was not demonstrating the usage.I can PR this one also after thes changes are approved.
--- Changes ---
--- In Process ---