Adds makefile and define single word command. #6
Conversation
This reverts commit 9c474c4.
There was a problem hiding this comment.
In general I don't think the make dependency is needed here.
I like the idea of custom word lists. We should use vim's spell file (for me that's ~/.config/nvim/spell/en.utf-8.add), rather than our own, but also support additional files in a xdg config dir. Using the vim files adding a word is just zg.
Generating the words from the user's wordnet install is going to be difficult.
ls /*/*/*/index.[anv]* won't work on my nixos machine, since it's dir structures are different.
You could produce the file using the GitHub action and then periodical commit it. That would also have the benefit of updating the wordnet file via standard vim plugin managers.
Thanks for your PR.
|
Personally I don't like the idea of using vim's spell file. At first I redirected words to "/usr/share/dict/words" on my Ubuntu machine and ran into the issue that word net not having definitions for everything in that file. I think the same thing would happen if we used the spell file. I should also mention that my use-case for this plugin is to make sure I am using words correctly (e.x. effect v.s. affect) not to replace vim's normal spelling system. That is the reason that "DefineWord" is the way that it is. I will move the makefile over to being used for building the wordfile though a GitHub action though. That seems the the best solution. |
|
|
Added a makefile that creates the words file that is as up to date as possible with the system.
Also adds a command and function that define a singe word.
Added a Build badge for the makefile with Github Actions.