Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI and Styling for Contact Management App #889

Conversation

mawalou14
Copy link
Contributor

@mawalou14 mawalou14 commented Oct 13, 2024

Closes: #823

  • Title: Update UI and Styling for Contact Management App
  • Name: Mouhamadou Awalou
  • Idenitfy yourself: Contributor in Hacktoberfest

Describe the add-ons or changes you've made 📃

In this contribution, I have updated the UI and styling of the Contact Management App located in the advanced section of the Angular-js projects. The changes include improved visual elements for better user experience, including a responsive layout, updated color schemes, and enhanced component styling.
Also, updated the readme.md file of this project by replacing the screenshots with the new look.

Screenshots 📷

contact management app
noContactFound
successPopup

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Please review the UI changes and provide feedback on the overall design and usability improvements. I appreciate your input!. The background image used is a free picture downloaded from freepik.com.

mawalou14 and others added 2 commits October 13, 2024 00:39
Updated the screenshots found in the readme.md file of the contact management angular application
Copy link

vercel bot commented Oct 13, 2024

@mawalou14 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link
Owner

@Avdhesh-Varshney Avdhesh-Varshney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete all the .angular cache files and other any un-necessary files.

@Avdhesh-Varshney Avdhesh-Varshney added bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Oct 13, 2024
@Avdhesh-Varshney
Copy link
Owner

Can you tell what you have improved except bg addition?

@Avdhesh-Varshney Avdhesh-Varshney added the question❓ Further information is requested label Oct 13, 2024
@mawalou14
Copy link
Contributor Author

Can you tell what you have improved except bg addition?

I've made serceral improvements beyond just adding the background image. Here are the changes and improvements I made:

  • Added toastr notifications for all operations ( Add, Update, Delete).
  • Updated the subscription syntax to follow best practices.
  • Removed unnecessary full-page reloads by notifying the contact list component via the contact service, ensuring smooth updates.
  • Added meaningful comments to help other developers understand the changes.
  • Improved UI layout by making the header fixed and placing the search bar in the header.
  • Added a "No contact found" message when the contact list is empty.
  • Updated the README.md for better documentation and understanding.

@mawalou14
Copy link
Contributor Author

Delete all the .angular cache files and other any un-necessary files.

Hi @Avdhesh-Varshney. Done, I've pushed the requested changes, and all feedback has been implemented.

@Avdhesh-Varshney Avdhesh-Varshney removed the question❓ Further information is requested label Oct 15, 2024
@mawalou14 mawalou14 force-pushed the angular/advanced/contact-ui-update branch from aefada1 to ece84cb Compare October 15, 2024 17:21
@Avdhesh-Varshney Avdhesh-Varshney merged commit 1603366 into Avdhesh-Varshney:main Oct 17, 2024
2 of 3 checks passed
@Avdhesh-Varshney Avdhesh-Varshney added enhancement 🧑‍💻 New feature or request level2 Intermediate level issues/pull requests Approved ✔️ This PR is approved by the PR or, Mentors gssoc-ext gssoc-extended 2024 hacktoberfest-accepted Hacktoberfest 2024 and removed bug 🐛 Something isn't working Requested Changes ⚙️ Some changes have been requested in this PR labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved ✔️ This PR is approved by the PR or, Mentors enhancement 🧑‍💻 New feature or request gssoc-ext gssoc-extended 2024 hacktoberfest-accepted Hacktoberfest 2024 level2 Intermediate level issues/pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🧑‍💻: UI and Styling Improvements for Contact Manaher Application
2 participants