Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer should always be at the bottom of the page which is not the case here #811 #834

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

tarunkumar2005
Copy link
Contributor

Closes: #811

-Footer should always be at the bottom of the page which is not the case here #811

  • Tarun kumar
  • GSSOC 2024 ext and hacktoberfest

Describe the add-ons or changes you've made 📃

I have fixed the issue that the footer is not in the bottom of the page when the content is less on the page. i have provided the before and after screenshots.

Screenshots 📷

Before :-

image

After :-

image

image

This is for all the pages.

Type of change ☑️

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

@Avdhesh-Varshney Check this PR and merge this and assign this to me and add relevent labels like gssoc 2024 ext, hacktoberfest and level.

Copy link

vercel bot commented Oct 9, 2024

@tarunkumar2005 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 9, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-master-log ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 4:53pm

@Avdhesh-Varshney Avdhesh-Varshney merged commit b2d63d5 into Avdhesh-Varshney:main Oct 9, 2024
4 checks passed
@Avdhesh-Varshney
Copy link
Owner

Never commit your pr in main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛: Footer should always be at the bottom of the page which is not the case here
2 participants