Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Amazon Clone Frontend #725

Closed
wants to merge 2 commits into from

Conversation

shellygarg10
Copy link

@shellygarg10 shellygarg10 commented Aug 2, 2024

Closes: #714

  • Title : Amazon Clone Frontend
  • Name: : Shelly Garg
  • Idenitfy yourself: : GSSOC 24

Describe the add-ons or changes you've made 📃

Added a project made using basics of HTML and CSS.

How Has This Been Tested? ⚙️

Screenshots 📷

image

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: ☑️

  • My code follows the Contributing Guidelines & Code of Conduct of this project.
  • This PR does not contain plagiarized content.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • My changes generate no new warnings.

Note to reviewers 📄

Copy link

vercel bot commented Aug 2, 2024

@shellygarg10 is attempting to deploy a commit to the avdheshvarshney's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Aug 2, 2024

Thank you for submitting your pull request! We'll review it as soon as possible. For further communication, join our discord server https://discord.gg/tSqtvHUJzE.

@Avdhesh-Varshney Avdhesh-Varshney added Status: Requested Changes Warning: Follow Guidelines https://github.com/Avdhesh-Varshney/WebMasterLog/issues/108 labels Aug 3, 2024
@shellygarg10
Copy link
Author

@Avdhesh-Varshney can you please explain the issues to me

@shellygarg10
Copy link
Author

@Avdhesh-Varshney i made corrections and followed all the guidelines correctly now , please review my pr once again

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

convert it into webp format and rename it to screenshot.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to correct your image in your project readme file.

@@ -47,7 +47,7 @@
| 20 | [Login Signup Form](./Basic//Login-Signup-Form) | ![Basic](https://img.shields.io/badge/Basic-00FF00?style=for-the-badge) |
| 21 | [Feedback Form](./Basic//Feedback-Form) | ![Basic](https://img.shields.io/badge/Basic-00FF00?style=for-the-badge) |
| 22 | [Survey Form](./Basic//Survey-Form) | ![Basic](https://img.shields.io/badge/Basic-00FF00?style=for-the-badge) |

| 23 | [Amazon Clone](./Basic//Amazon_clone) | ![Basic](https://img.shields.io/badge/Basic-00FF00?style=for-the-badge) |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct here also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Flag: Inactive Flag: Invalid Warning: Follow Guidelines https://github.com/Avdhesh-Varshney/WebMasterLog/issues/108 wontfix ❌ This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants